Bug 62466 - [chromium] Dragging images to Mail.app results in broken attachments
Summary: [chromium] Dragging images to Mail.app results in broken attachments
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-10 11:04 PDT by Daniel Cheng
Modified: 2013-04-08 13:15 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2011-06-10 11:07 PDT, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2011-06-10 11:04:21 PDT
Original bug: http://code.google.com/p/chromium/issues/detail?id=55879
Comment 1 Daniel Cheng 2011-06-10 11:07:53 PDT
Created attachment 96761 [details]
Patch
Comment 2 Tony Chang 2011-06-10 11:20:19 PDT
Comment on attachment 96761 [details]
Patch

What happens on Firefox?  Also out of curiosity, what does IE do on Windows?
Comment 3 Tony Chang 2011-06-10 11:20:52 PDT
(In reply to comment #2)
> (From update of attachment 96761 [details])
> Also out of curiosity, what does IE do on Windows?

I ask because I'm not sure if we should #ifdef this or just remove it completely.
Comment 4 Eric Seidel (no email) 2011-06-13 14:56:04 PDT
Comment on attachment 96761 [details]
Patch

I would say we should add a manual-test, but I'm not sure how useful it is, except to remind us of the existence of this bug.
Comment 5 Tony Chang 2011-06-13 14:59:40 PDT
I don't think Eric read the comments on the bug.

Anyway, it's fine to commit, but if it turns out that FF and IE don't put an <img> tag on the clipboard when dragging an image, we should just remove the code.
Comment 6 WebKit Review Bot 2011-06-13 15:06:32 PDT
Comment on attachment 96761 [details]
Patch

Clearing flags on attachment: 96761

Committed r88704: <http://trac.webkit.org/changeset/88704>
Comment 7 WebKit Review Bot 2011-06-13 15:06:36 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Dimitri Glazkov (Google) 2011-06-13 15:39:42 PDT
Reverted r88704 for reason:

Caused layout test failures on Chromium Mac.

Committed r88721: <http://trac.webkit.org/changeset/88721>
Comment 10 Daniel Cheng 2013-04-08 13:15:16 PDT
Fixed on the Chromium-side using a better approach.