Bug 62466 – [chromium] Dragging images to Mail.app results in broken attachments

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Platform

[Daniel Cheng]

Original bug: http://code.google.com/p/chromium/issues/detail?id=55879

[Daniel Cheng]

Created attachment 96761 [details]
Patch

[Tony Chang]

Comment on attachment 96761 [details]
Patch

What happens on Firefox?  Also out of curiosity, what does IE do on Windows?

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 96761 [details])
> Also out of curiosity, what does IE do on Windows?

I ask because I'm not sure if we should #ifdef this or just remove it completely.

[Eric Seidel (no email)]

Comment on attachment 96761 [details]
Patch

I would say we should add a manual-test, but I'm not sure how useful it is, except to remind us of the existence of this bug.

[Tony Chang]

I don't think Eric read the comments on the bug.

Anyway, it's fine to commit, but if it turns out that FF and IE don't put an <img> tag on the clipboard when dragging an image, we should just remove the code.

[WebKit Review Bot]

Comment on attachment 96761 [details]
Patch

Clearing flags on attachment: 96761

Committed r88704: <http://trac.webkit.org/changeset/88704>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Dimitri Glazkov (Google)]

Reverted r88704 for reason:

Caused layout test failures on Chromium Mac.

Committed r88721: <http://trac.webkit.org/changeset/88721>

[Dimitri Glazkov (Google)]

Here are the breakages: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&group=%40ToT%20-%20chromium.org&tests=editing%2Fpasteboard%2F4947130.html%2Cediting%2Fpasteboard%2Fdrag-image-to-contenteditable-in-iframe.html%2Cediting%2Fpasteboard%2Fdrag-selected-image-to-contenteditable.html%2Cediting%2Fselection%2Fdrag-to-contenteditable-iframe.html%2Cediting%2Fpasteboard%2Fdrag-image-in-about-blank-frame.html%2Cfast%2Fevents%2Fstandalone-image-drag-to-editable.html%2Chttp%2Ftests%2Fsecurity%2Fdrag-drop-same-unique-origin.html

[Daniel Cheng]

Fixed on the Chromium-side using a better approach.