Bug 62448 - [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space
Summary: [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 colo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-10 04:22 PDT by KwangHyuk
Modified: 2011-06-13 08:10 PDT (History)
9 users (show)

See Also:


Attachments
propose simple patch (2.23 KB, patch)
2011-06-10 04:49 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff
update change log (2.39 KB, patch)
2011-06-13 07:37 PDT, KwangHyuk
kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
add more accurate explaination for this patch into ChangeLog (2.26 KB, patch)
2011-06-13 07:59 PDT, KwangHyuk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangHyuk 2011-06-10 04:22:04 PDT
As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of CAIRO_FORMAT_RGB24.
Comment 1 KwangHyuk 2011-06-10 04:49:49 PDT
Created attachment 96735 [details]
propose simple patch
Comment 2 Gyuyoung Kim 2011-06-10 04:55:02 PDT
LGTM.
Comment 3 Lucas De Marchi 2011-06-10 06:17:29 PDT
CC'ing Antognolli
Comment 4 Rafael Antognolli 2011-06-13 07:14:41 PDT
(In reply to comment #1)
> Created an attachment (id=96735) [details]
> propose simple patch

LGTM too. But could you please give more details about why are you doing this kind of change?
Comment 5 KwangHyuk 2011-06-13 07:37:37 PDT
Created attachment 96953 [details]
update change log

This patch was useful when pixman is using bilinear filter.
Comment 6 Kenneth Rohde Christiansen 2011-06-13 07:47:47 PDT
Comment on attachment 96953 [details]
update change log

View in context: https://bugs.webkit.org/attachment.cgi?id=96953&action=review

> Source/WebKit/efl/ChangeLog:12
> +        As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default
> +        cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of
> +        CAIRO_FORMAT_RGB24, since pixman does not support the fast path from
> +        src:argb32 to dst:rgb24 for source over operation when pixman is using
> +        bilinear filter

The English could be improved a bit there.

Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter. 

Or similar :-) Not sure if that is exactly what you are saying though.
Comment 7 KwangHyuk 2011-06-13 07:56:02 PDT
Thank you, It's the thing what I want to say, I better change ChangeLog one more time.
Comment 8 KwangHyuk 2011-06-13 07:59:42 PDT
Created attachment 96954 [details]
add more accurate explaination for this patch into ChangeLog
Comment 9 WebKit Review Bot 2011-06-13 08:10:11 PDT
Comment on attachment 96954 [details]
add more accurate explaination for this patch into ChangeLog

Clearing flags on attachment: 96954

Committed r88639: <http://trac.webkit.org/changeset/88639>
Comment 10 WebKit Review Bot 2011-06-13 08:10:16 PDT
All reviewed patches have been landed.  Closing bug.