As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of CAIRO_FORMAT_RGB24.
Created attachment 96735 [details] propose simple patch
LGTM.
CC'ing Antognolli
(In reply to comment #1) > Created an attachment (id=96735) [details] > propose simple patch LGTM too. But could you please give more details about why are you doing this kind of change?
Created attachment 96953 [details] update change log This patch was useful when pixman is using bilinear filter.
Comment on attachment 96953 [details] update change log View in context: https://bugs.webkit.org/attachment.cgi?id=96953&action=review > Source/WebKit/efl/ChangeLog:12 > + As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default > + cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of > + CAIRO_FORMAT_RGB24, since pixman does not support the fast path from > + src:argb32 to dst:rgb24 for source over operation when pixman is using > + bilinear filter The English could be improved a bit there. Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter. Or similar :-) Not sure if that is exactly what you are saying though.
Thank you, It's the thing what I want to say, I better change ChangeLog one more time.
Created attachment 96954 [details] add more accurate explaination for this patch into ChangeLog
Comment on attachment 96954 [details] add more accurate explaination for this patch into ChangeLog Clearing flags on attachment: 96954 Committed r88639: <http://trac.webkit.org/changeset/88639>
All reviewed patches have been landed. Closing bug.