RESOLVED FIXED 62448
[EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 color space 
https://bugs.webkit.org/show_bug.cgi?id=62448
Summary [EFL] change of cairo_format_t corresponding to EVAS_COLORSPACE_ARGB8888 colo...
KwangHyuk
Reported 2011-06-10 04:22:04 PDT
As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of CAIRO_FORMAT_RGB24.
Attachments
propose simple patch (2.23 KB, patch)
2011-06-10 04:49 PDT, KwangHyuk 		no flags
DetailsFormatted DiffDiff
update change log (2.39 KB, patch)
2011-06-13 07:37 PDT, KwangHyuk 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
add more accurate explaination for this patch into ChangeLog (2.26 KB, patch)
2011-06-13 07:59 PDT, KwangHyuk 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
KwangHyuk
Comment 1 2011-06-10 04:49:49 PDT
Created attachment 96735 [details] propose simple patch
Gyuyoung Kim
Comment 2 2011-06-10 04:55:02 PDT
LGTM.
Lucas De Marchi
Comment 3 2011-06-10 06:17:29 PDT
CC'ing Antognolli
Rafael Antognolli
Comment 4 2011-06-13 07:14:41 PDT
(In reply to comment #1) > Created an attachment (id=96735) [details] > propose simple patch LGTM too. But could you please give more details about why are you doing this kind of change?
KwangHyuk
Comment 5 2011-06-13 07:37:37 PDT
Created attachment 96953 [details] update change log This patch was useful when pixman is using bilinear filter.
Kenneth Rohde Christiansen
Comment 6 2011-06-13 07:47:47 PDT
Comment on attachment 96953 [details] update change log View in context: https://bugs.webkit.org/attachment.cgi?id=96953&action=review > Source/WebKit/efl/ChangeLog:12 > + As GraphicContextCairo is using CAIRO_FORMAT_ARGB32 as default > + cairo_format_t, ewk better to use CAIRO_FORMAT_ARGB32 too instead of > + CAIRO_FORMAT_RGB24, since pixman does not support the fast path from > + src:argb32 to dst:rgb24 for source over operation when pixman is using > + bilinear filter The English could be improved a bit there. Use CAIRO_FORMAT_ARGB32 for EWK as pixman does not support the fast path for converting from ARGB32 to AGB24 when using source over operation in combination with a bilinear filter. Or similar :-) Not sure if that is exactly what you are saying though.
KwangHyuk
Comment 7 2011-06-13 07:56:02 PDT
Thank you, It's the thing what I want to say, I better change ChangeLog one more time.
KwangHyuk
Comment 8 2011-06-13 07:59:42 PDT
Created attachment 96954 [details] add more accurate explaination for this patch into ChangeLog
WebKit Review Bot
Comment 9 2011-06-13 08:10:11 PDT
Comment on attachment 96954 [details] add more accurate explaination for this patch into ChangeLog Clearing flags on attachment: 96954 Committed r88639: <http://trac.webkit.org/changeset/88639>
WebKit Review Bot
Comment 10 2011-06-13 08:10:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.