Bug 62442 - [Qt] LayoutTestController needs setTextDirection implementation
Summary: [Qt] LayoutTestController needs setTextDirection implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Mahesh Kulkarni
URL:
Keywords: Qt
Depends on: 62517
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-10 02:14 PDT by Mahesh Kulkarni
Modified: 2011-06-12 21:13 PDT (History)
4 users (show)

See Also:

Attachments
patch (3.40 KB, patch)
2011-06-10 02:21 PDT, Mahesh Kulkarni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mahesh Kulkarni 2011-06-10 02:14:55 PDT 
fast/html/set-text-direction.html is failing in Qt port because LayoutTestController needs setTextDirection implementation.
Comment 1 Mahesh Kulkarni 2011-06-10 02:21:43 PDT 
Created attachment 96717 [details]
patch

Implements setTextDirection using QWebPage actions.
Comment 2 Ryosuke Niwa 2011-06-12 13:27:17 PDT 
It seems like findString.html is failing on Qt bot after this patch is landed:
http://build.webkit.org/results/Qt%20Linux%20Release/r88616%20(34105)/results.html
http://build.webkit.org/results/Qt%20Linux%20Release/r88619%20(34108)/results.html
Comment 3 Antonio Gomes 2011-06-12 14:21:21 PDT 
Do you need to reset the direction value before each test execution?
Comment 4 Antonio Gomes 2011-06-12 14:58:36 PDT 
rolled out by  to fix the test offline.
Comment 5 Mahesh Kulkarni 2011-06-12 20:20:03 PDT 
(In reply to comment #3)
> Do you need to reset the direction value before each test execution?

Sorry for the confusion created, This bug fixes only 
> # LayoutTestController::setTextDirection is not implemented. 
>       fast/html/set-text-direction.html 

I was working next on findString() and committed with below case commented. 
> # Missing layoutTestController.findString() http://webkit.org/b/50236 
> #     editing/text-iterator/findString.html 

I will use webkit-patch land-attachment from now on and land the patch reviewed :)
Comment 6 Mahesh Kulkarni 2011-06-12 21:13:24 PDT 
Comment on attachment 96717 [details]
patch

Clearing flags on attachment: 96717

Committed r88626: <http://trac.webkit.org/changeset/88626>
Comment 7 Mahesh Kulkarni 2011-06-12 21:13:34 PDT 
All reviewed patches have been landed.  Closing bug.