Bug 62428 - ShadowContentElement should detach its inclusions before attach them.
Summary: ShadowContentElement should detach its inclusions before attach them.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 62202
  Show dependency tree / graph
 
Reported: 2011-06-09 22:09 PDT by Hajime Morrita
Modified: 2011-06-14 23:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.68 KB, patch)
2011-06-09 23:05 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Updated to ToT (6.69 KB, patch)
2011-06-12 22:57 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (6.70 KB, patch)
2011-06-13 22:45 PDT, Hajime Morrita 		dglazkov: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-06-09 22:09:13 PDT 
This is a preparation for Bug 59802.
Comment 1 Hajime Morrita 2011-06-09 23:05:50 PDT 
Created attachment 96697 [details]
Patch
Comment 2 Hajime Morrita 2011-06-12 22:57:13 PDT 
Created attachment 96921 [details]
Updated to ToT
Comment 3 Dimitri Glazkov (Google) 2011-06-13 15:13:41 PDT 
Comment on attachment 96921 [details]
Updated to ToT

View in context: https://bugs.webkit.org/attachment.cgi?id=96921&action=review

> Source/WebCore/ChangeLog:5
> +        ShadowContentElement should detach its inclusions before attach them.

"before attaching them".

> Source/WebCore/dom/ShadowContentElement.cpp:40
> +        selector->selectIncludesion(m_inclusions);

includesion is not a real word. Did you mean inclusion?
Comment 4 Hajime Morrita 2011-06-13 22:45:44 PDT 
Created attachment 97069 [details]
Patch
Comment 5 Hajime Morrita 2011-06-14 23:24:35 PDT 
Committed r88908: <http://trac.webkit.org/changeset/88908>