Bug 62423 – [Chromium] Add WebSettings::setShouldPrintBackgrounds()

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Lei Zhang]

Created attachment 96688 [details]
Patch to add setShouldPrintBackgrounds()

Hook up setShouldPrintBackgrounds for http://crbug.com/2294

[Lei Zhang]

+fishd

[Darin Fisher (:fishd, Google)]

Comment on attachment 96688 [details]
Patch to add setShouldPrintBackgrounds()

View in context: https://bugs.webkit.org/attachment.cgi?id=96688&action=review

Patch looks good except for the ChangeLog entry.

> WebKit/chromium/ChangeLog:5
> +        Need a short description and bug URL (OOPS!)

you need to do as this says :)

[Lei Zhang]

Created attachment 97000 [details]
Added comment to ChangeLog

Whoops indeed.

[Darin Fisher (:fishd, Google)]

Comment on attachment 97000 [details]
Added comment to ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=97000&action=review

You forgot to set the '?' on the patch, which meant that it didn't
go into the review request queue :-(

> WebKit/chromium/ChangeLog:5
> +        [Chromium] Add a WebSetting to control printing backgrounds

sorry to give you a hard time, but you are also supposed to include
the URL of this bug report here.  please take a look at how other
people write ChangeLog entries.

[Lei Zhang]

Created attachment 97020 [details]
Add bug url to changelog

That's ok. Third time is the charm.

[WebKit Review Bot]

Comment on attachment 97020 [details]
Add bug url to changelog

Clearing flags on attachment: 97020

Committed r88728: <http://trac.webkit.org/changeset/88728>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.