Bug 62397 - [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
Summary: [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 13:23 PDT by James Robinson
Modified: 2011-06-09 17:30 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.33 KB, patch)
2011-06-09 13:26 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Patch (3.56 KB, patch)
2011-06-09 13:46 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
re-upload to let EWS chew on it again (3.56 KB, patch)
2011-06-09 15:41 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2011-06-09 13:23:29 PDT 
[chromium] webkitRequestFullscreen exposed to web even when feature is disabled
Comment 1 James Robinson 2011-06-09 13:26:10 PDT 
Created attachment 96628 [details]
Patch
Comment 2 James Robinson 2011-06-09 13:46:45 PDT 
Created attachment 96632 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-06-09 13:56:09 PDT 
Comment on attachment 96632 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2011-06-09 14:32:18 PDT 
Comment on attachment 96632 [details]
Patch

Rejecting attachment 96632 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
rror: 'toRenderFullScreen' was not declared in this scope
Source/WebCore/html/HTMLMediaElement.cpp:2726: error: invalid use of incomplete type 'struct WebCore::RenderFullScreen'
Source/WebCore/dom/Document.h:114: error: forward declaration of 'struct WebCore::RenderFullScreen'
  CXX(target) out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMeterElement.o
make: *** [out/Debug/obj.target/webcore_html/Source/WebCore/html/HTMLMediaElement.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/8812817
Comment 5 James Robinson 2011-06-09 14:36:25 PDT 
Looks like the ENABLE_FULLSCREEN_API=0 path has compile-rotted on mac (and apparently on win too from my trybot results).  I'll update the patch...
Comment 6 WebKit Review Bot 2011-06-09 14:37:26 PDT 
Comment on attachment 96632 [details]
Patch

Attachment 96632 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8826167
Comment 7 James Robinson 2011-06-09 15:41:22 PDT 
Created attachment 96655 [details]
re-upload to let EWS chew on it again
Comment 8 James Robinson 2011-06-09 15:42:00 PDT 
This should compile now that http://trac.webkit.org/changeset/88490 has landed.
Comment 9 James Robinson 2011-06-09 17:30:40 PDT 
Committed r88507: <http://trac.webkit.org/changeset/88507>