RESOLVED FIXED 62395
IndexedDB: objectStore.transaction property should be readonly 
https://bugs.webkit.org/show_bug.cgi?id=62395
Summary IndexedDB: objectStore.transaction property should be readonly
Mark Pilgrim (Google)
Reported 2011-06-09 13:05:53 PDT
Created attachment 96621 [details] test case http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-transaction states that the transaction property of an object store is readonly, but setting it changes the value. Test case attached.
Attachments
test case (2.23 KB, text/html)
2011-06-09 13:05 PDT, Mark Pilgrim (Google) 		no flags
Details
Patch (9.13 KB, patch)
2011-10-21 11:28 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (9.13 KB, patch)
2011-10-21 13:16 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2011-10-21 11:28:44 PDT
Created attachment 111994 [details] Patch
Adam Barth
Comment 2 2011-10-21 12:48:04 PDT
Comment on attachment 111994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111994&action=review > Source/WebCore/storage/IDBObjectStore.cpp:71 > +PassRefPtr<IDBTransaction> IDBObjectStore::transaction() const This should just be a raw pointer. > Source/WebCore/storage/IDBObjectStore.idl:34 > + readonly attribute IDBTransaction transaction; I assume this is in the spec.
Joshua Bell
Comment 3 2011-10-21 13:16:13 PDT
Created attachment 112007 [details] Patch
Joshua Bell
Comment 4 2011-10-21 13:18:46 PDT
Thanks, and yes - it is defined in the spec - added a mention of that in the ChangeLog note. Also tracked as crbug.com/92042
Adam Barth
Comment 5 2011-10-21 13:27:33 PDT
Comment on attachment 112007 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112007&action=review > Source/WebCore/ChangeLog:8 > + Implement the IDBObjectStore.transaction property defined by the spec. Yeah, I saw this line but I couldn't verify it because there wasn't a link. A link isn't necessary, that's why I mentioned that I'm trusted you that it's in the spec. :)
WebKit Review Bot
Comment 6 2011-10-21 14:29:18 PDT
Comment on attachment 112007 [details] Patch Clearing flags on attachment: 112007 Committed r98154: <http://trac.webkit.org/changeset/98154>
WebKit Review Bot
Comment 7 2011-10-21 14:29:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.