Bug 62394 - [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support
Summary: [CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leandro Pereira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 13:05 PDT by Leandro Pereira
Modified: 2011-06-13 15:23 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.45 KB, patch)
2011-06-09 13:22 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff
Patch (2.57 KB, patch)
2011-06-09 13:44 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2011-06-09 13:05:05 PDT
[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms without plugin support
Comment 1 Leandro Pereira 2011-06-09 13:22:48 PDT
Created attachment 96625 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-06-09 13:36:49 PDT
Comment on attachment 96625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96625&action=review

> Source/WebCore/CMakeLists.txt:-1507
> -    LIST(APPEND WebCore_SOURCES
> -        plugins/PluginPackageNone.cpp
> -        plugins/PluginViewNone.cpp
> -    )

IMO you also need to add PluginPackageNone and PluginViewNone in the ELSE() at CMakeListsWinCE.txt.
Comment 3 Leandro Pereira 2011-06-09 13:44:28 PDT
Created attachment 96631 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-06-13 15:06:45 PDT
Comment on attachment 96631 [details]
Patch

OK.  rs=me.
Comment 5 WebKit Review Bot 2011-06-13 15:23:34 PDT
Comment on attachment 96631 [details]
Patch

Clearing flags on attachment: 96631

Committed r88711: <http://trac.webkit.org/changeset/88711>
Comment 6 WebKit Review Bot 2011-06-13 15:23:38 PDT
All reviewed patches have been landed.  Closing bug.