RESOLVED FIXED 62364
[chromium-win] Register protocol handler tests are failing on build.webkit.org 
https://bugs.webkit.org/show_bug.cgi?id=62364
Summary [chromium-win] Register protocol handler tests are failing on build.webkit.org
Ryosuke Niwa
Reported 2011-06-09 02:46:27 PDT
It seems like the flags aren't enabled properly on build.webkit.org bots: http://build.webkit.org/results/Chromium%20Win%20Release%20(Tests)/r88434%20(15286)/results.html
Attachments
Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-06-09 13:13:41 PDT
This is a bit strange - it seems that the ENABLE_REGISTER_... macro is not on for these bots, although when I regenerate the visual studio projects locally it's definitely set to true. The bots need a kick perhaps?
Tony Chang
Comment 2 2011-06-09 14:21:52 PDT
I'll check on the bot.
Tony Chang
Comment 3 2011-06-09 14:30:00 PDT
Oh, in the checked in code, I think it's disabled for all upstream builds since it's set to 0 in the top of features.gypi. In chromium checkouts, features_override.gypi enables it. The reason the variable in build/common.gypi doesn't override is because in features.gypi, the nesting puts the condition in a scope that doesn't see the value in build/common.gypi. This will be fixed by bug 62399.
Tony Chang
Comment 4 2011-06-10 12:01:29 PDT
Seems green after landing the patch on bug 62399 and clobbering the build to pick up the compiler flag changes.
Ryosuke Niwa
Comment 5 2011-06-10 18:10:58 PDT
fast/dom/navigator-detached-no-crash.html is failing on Mac: http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html
Dimitri Glazkov (Google)
Comment 6 2011-06-11 10:59:49 PDT
(In reply to comment #5) > fast/dom/navigator-detached-no-crash.html is failing on Mac: > > http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html I re-clobbered teh bot. Let's see what happens.
Ryosuke Niwa
Comment 7 2011-06-22 19:03:45 PDT
It seems like the test has been passing, closing the bug.
Note You need to log in before you can comment on or make changes to this bug.