Bug 62364 - [chromium-win] Register protocol handler tests are failing on build.webkit.org
Summary: [chromium-win] Register protocol handler tests are failing on build.webkit.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-09 02:46 PDT by Ryosuke Niwa
Modified: 2011-06-22 19:03 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-09 02:46:27 PDT
It seems like the flags aren't enabled properly on build.webkit.org bots:
http://build.webkit.org/results/Chromium%20Win%20Release%20(Tests)/r88434%20(15286)/results.html
Comment 1 James Robinson 2011-06-09 13:13:41 PDT
This is a bit strange - it seems that the ENABLE_REGISTER_... macro is not on for these bots, although when I regenerate the visual studio projects locally it's definitely set to true.  The bots need a kick perhaps?
Comment 2 Tony Chang 2011-06-09 14:21:52 PDT
I'll check on the bot.
Comment 3 Tony Chang 2011-06-09 14:30:00 PDT
Oh, in the checked in code, I think it's disabled for all upstream builds since it's set to 0 in the top of features.gypi.  In chromium checkouts, features_override.gypi enables it.

The reason the variable in build/common.gypi doesn't override is because in features.gypi, the nesting puts the condition in a scope that doesn't see the value in build/common.gypi.

This will be fixed by bug 62399.
Comment 4 Tony Chang 2011-06-10 12:01:29 PDT
Seems green after landing the patch on bug 62399 and clobbering the build to pick up the compiler flag changes.
Comment 5 Ryosuke Niwa 2011-06-10 18:10:58 PDT
fast/dom/navigator-detached-no-crash.html is failing on Mac:

http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html
Comment 6 Dimitri Glazkov (Google) 2011-06-11 10:59:49 PDT
(In reply to comment #5)
> fast/dom/navigator-detached-no-crash.html is failing on Mac:
> 
> http://build.webkit.org/results/Chromium%20Mac%20Release%20(Tests)/r88574%20(8082)/fast/dom/navigator-detached-no-crash-pretty-diff.html

I re-clobbered teh bot. Let's see what happens.
Comment 7 Ryosuke Niwa 2011-06-22 19:03:45 PDT
It seems like the test has been passing, closing the bug.