62337 – Factored a bunch of Heap functionality into stand-alone functors

Bug 62337 - Factored a bunch of Heap functionality into stand-alone functors

Summary: Factored a bunch of Heap functionality into stand-alone functors

Attachments
Patch (22.38 KB, patch) 2011-06-08 16:31 PDT, Geoffrey Garen	oliver: review+ webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
windows build fix (1.51 KB, patch) 2011-06-09 12:36 PDT, Geoffrey Garen	oliver: review+	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Geoffrey Garen 2011-06-08 16:22:25 PDT

Factored a bunch of Heap functionality into stand-alone functors

Comment 1 Geoffrey Garen 2011-06-08 16:31:54 PDT

Created attachment 96505 [details]
Patch

Comment 2 WebKit Review Bot 2011-06-09 04:35:14 PDT

Comment on attachment 96505 [details]
Patch

Attachment 96505 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8777979

Comment 3 Geoffrey Garen 2011-06-09 12:36:13 PDT

Created attachment 96618 [details]
windows build fix

Comment 4 Oliver Hunt 2011-06-09 12:36:50 PDT

Comment on attachment 96618 [details]
windows build fix

r+, but we don't typically need review for build fixes

Comment 5 Geoffrey Garen 2011-06-09 12:44:41 PDT

Committed r88473: <http://trac.webkit.org/changeset/88473>

Comment 6 Geoffrey Garen 2011-06-09 12:52:37 PDT

Heh -- I was just uploading because that's the best way to get a file back to my Mac from the Windows trybot :).