Bug 62332 – [WKView _setDragImage:at:linkDrag:] can crash if WKView is dealloc'ed during drag

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[John Sullivan]

[WKView _setDragImage:at:linkDrag:] contains a call to super that performs a drag. It's possible for this call to super to end up dealloc'ing self, and then WebKit will crash on the line of code that runs after the call to [super dragImage::::::].

This is in Radar as 9355199

[John Sullivan]

Created attachment 96492 [details]
Patch to retain self during this method

[Darin Adler]

Comment on attachment 96492 [details]
Patch to retain self during this method

View in context: https://bugs.webkit.org/attachment.cgi?id=96492&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2342
> +    RetainPtr<WKView> protect(self);

It’s better to use a noun for the name of the local variable. Say, protector, instead of protect.

[John Sullivan]

Will change to "protector". I used "protect" in mimicry of another function in this file. I'll change that one too while I'm in here.

[John Sullivan]

Fixed in <http://trac.webkit.org/changeset/88401>.