WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62327
Add faster lookup cache for multi character identifiers
https://bugs.webkit.org/show_bug.cgi?id=62327
Summary
Add faster lookup cache for multi character identifiers
Oliver Hunt
Reported
2011-06-08 14:17:56 PDT
Add faster lookup cache for multi character identifiers
Attachments
Patch
(3.64 KB, patch)
2011-06-08 14:22 PDT
,
Oliver Hunt
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Oliver Hunt
Comment 1
2011-06-08 14:22:38 PDT
Created
attachment 96481
[details]
Patch
Oliver Hunt
Comment 2
2011-06-08 14:23:25 PDT
This is a 1.7% parsing improvement by my measurements.
Geoffrey Garen
Comment 3
2011-06-08 14:31:30 PDT
Comment on
attachment 96481
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=96481&action=review
r=me
> Source/JavaScriptCore/parser/ParserArena.h:82 > + if (ident && ident->length() == (int)length && (!memcmp(characters, ident->characters(), length * sizeof(UChar))))
static_cast<int>, please.
Geoffrey Garen
Comment 4
2011-06-08 14:35:22 PDT
Just realized that Identifier::equal might be a better choice than memcmp.
Oliver Hunt
Comment 5
2011-06-08 14:57:34 PDT
Committed
r88394
: <
http://trac.webkit.org/changeset/88394
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug