Bug 62307 - Fix clang issue, virtual function const mismatch
Summary: Fix clang issue, virtual function const mismatch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Simonsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-08 12:40 PDT by James Simonsen
Modified: 2011-06-09 14:28 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2011-06-08 12:47 PDT, James Simonsen 		tonyg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Simonsen 2011-06-08 12:40:50 PDT 
Fix clang issue, virtual function const mismatch
Comment 1 James Simonsen 2011-06-08 12:47:48 PDT 
Created attachment 96463 [details]
Patch
Comment 2 James Simonsen 2011-06-08 13:44:01 PDT 
Committed r88382: <http://trac.webkit.org/changeset/88382>
Comment 3 Darin Adler 2011-06-08 15:43:56 PDT 
Comment on attachment 96463 [details]
Patch

This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken.
Comment 4 James Simonsen 2011-06-09 13:41:31 PDT 
(In reply to comment #3)
> (From update of attachment 96463 [details])
> This almost certainly had some real symptom too. When possible we try to make a test case to show what was broken.

Fortunately, the code was only broken in the tree for several hours. Chromium runs clang on all WebKit rolls and those happen a few times a day. I expect that we'll catch these sorts of bugs pretty quickly.

I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems.
Comment 5 Adam Barth 2011-06-09 14:23:26 PDT 
> I hope someone is working on a Clang EWS bot. That would be even quicker at detecting these sorts of problems.

Great idea.  I'll talk to Nico about that.
Comment 6 Adam Barth 2011-06-09 14:28:48 PDT 
The instructions are here.  We'll need to adapt them a bit to work for WebKit:

http://code.google.com/p/chromium/wiki/Clang

This isn't high on my priority list, but it definitely sounds like something we should do.