Add Web Audio support to chromium DRT
Created attachment 96502 [details] Patch
Comment on attachment 96502 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96502&action=review > Source/WebKit/chromium/features.gypi:97 > + 'ENABLE_WEB_AUDIO=1', There's a comment in src/build/features_override.gypi saying that for the moment, Windows is only enabled for Google-branded builds. Is this still the case?
Yes the comment is still true. Does chromium DRT use features_override.gypi??? If so, then I can take out the change to features.gypi
(In reply to comment #3) > Yes the comment is still true. Does chromium DRT use features_override.gypi??? > If so, then I can take out the change to features.gypi It doesn't, but does that mean that web audio won't work with Chromium DRT on Windows? I.e., will the tests pass on Chromium Win bots?
Created attachment 96998 [details] Patch
Comment on attachment 96998 [details] Patch Attachment 96998 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8836320 New failing tests: fast/dom/prototype-inheritance.html
Created attachment 97004 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment on attachment 96998 [details] Patch rubber-stamp R+ so that we can put the updated patch in the CQ.
Comment on attachment 96998 [details] Patch Rejecting attachment 96998 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: sts passed (64.2%) => Tests to be fixed (1217): 7 DumpRenderTree crashes ( 0.6%) 4 tests timed out ( 0.3%) 49 text diff mismatch ( 4.0%) 326 skipped (26.8%) => Tests that will only be fixed if they crash (WONTFIX) (8113): 1 test timed out ( 0.0%) 109 text diff mismatch ( 1.3%) 7954 skipped (98.0%) Regressions: Unexpected text diff mismatch : (1) fast/dom/prototype-inheritance.html = TEXT Full output: http://queues.webkit.org/results/8836355
Created attachment 97013 [details] Archive of layout-test-results from ec2-cq-01 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Committed r88726: <http://trac.webkit.org/changeset/88726>