Bug 62283 - [Qt] Support for the gnash flash player plugin
Summary: [Qt] Support for the gnash flash player plugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-06-08 08:12 PDT by Dawit A.
Modified: 2011-06-16 15:21 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (1.51 KB, patch)
2011-06-08 08:17 PDT, Dawit A. 		eric: review-
eric: commit-queue-
Details | Formatted Diff | Diff
proposed patch v2 (1.55 KB, patch)
2011-06-15 06:58 PDT, Dawit A. 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawit A. 2011-06-08 08:12:56 PDT 
Currently the gnash flash player does not work with QtWebKit. Instead it prints out the following error message:

ERROR: NPAPI ERROR: No GTK2 support in this browser! Have version 0

The fix for it is to use the same workaround as the one used for the nspluginwrapper (npwrapper) in PluginPackageQt.cpp.
Comment 1 Dawit A. 2011-06-08 08:17:14 PDT 
Created attachment 96424 [details]
proposed patch
Comment 2 Eric Seidel (no email) 2011-06-13 15:25:55 PDT 
Comment on attachment 96424 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96424&action=review

Do we not have any tests in the repository which use flash?

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

The OOPS in this line will cause your patch to fail the commit queue.  You need to replace this line with a list of tests or reasons why testing is impossible/impractical.
Comment 3 Dawit A. 2011-06-15 06:58:50 PDT 
Created attachment 97289 [details]
proposed patch v2

Fixed changelog.
Comment 4 Alexis Menard (darktears) 2011-06-15 07:15:12 PDT 
Comment on attachment 97289 [details]
proposed patch v2

LGTM.
Comment 5 WebKit Review Bot 2011-06-16 15:21:05 PDT 
Comment on attachment 97289 [details]
proposed patch v2

Clearing flags on attachment: 97289

Committed r89076: <http://trac.webkit.org/changeset/89076>
Comment 6 WebKit Review Bot 2011-06-16 15:21:10 PDT 
All reviewed patches have been landed.  Closing bug.