Bug 62282 – Web Inspector: script links are displayed with original line number in pretty-print mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Podivilov]

Web Inspector: script links are displayed with original line number in pretty-print mode.

[Pavel Podivilov]

Created attachment 96422 [details]
Patch.

[Yury Semikhatsky]

Comment on attachment 96422 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review

> Source/WebCore/inspector/front-end/Panel.js:394
> +        linkText += ":" + (lineNumber + 1);

Common panel code shouldn't contain lineNumber arithmetic.

> Source/WebCore/inspector/front-end/inspector.js:1280
> +    var node = this.panels[preferredPanel].createAnchor(url, lineNumber - 1, classes, tooltipText);

This method shouldn't modify lineNumber.

[Yury Semikhatsky]

Comment on attachment 96422 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:106
> +    {

Anchors may be removed so there should be corresponding method that would remove them from _anchors here.

[Pavel Podivilov]

(In reply to comment #2)
> (From update of attachment 96422 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96422&action=review
> 
> > Source/WebCore/inspector/front-end/Panel.js:394
> > +        linkText += ":" + (lineNumber + 1);
> 
> Common panel code shouldn't contain lineNumber arithmetic.
> 
> > Source/WebCore/inspector/front-end/inspector.js:1280
> > +    var node = this.panels[preferredPanel].createAnchor(url, lineNumber - 1, classes, tooltipText);
> 
> This method shouldn't modify lineNumber.

Added fixme to make console call frame line/column numbers zero-based just like in debugger call frames.

> Anchors may be removed so there should be corresponding method that would remove them from _anchors here.

Anchors are cleared on navigation, so we may keep removed anchors in the list.

[Pavel Podivilov]

Created attachment 96564 [details]
Patch.

[Eric Seidel (no email)]

Comment on attachment 96564 [details]
Patch.

How do we test this?

[Pavel Podivilov]

Created attachment 97268 [details]
Added test.

[Yury Semikhatsky]

Comment on attachment 97268 [details]
Added test.

View in context: https://bugs.webkit.org/attachment.cgi?id=97268&action=review

> Source/WebCore/inspector/front-end/inspector.js:1281
> +    // FIXME: stack trace line/column numbers are one-based.

Please file a bug on this.

[Pavel Podivilov]

Committed r88927: <http://trac.webkit.org/changeset/88927>

[Pavel Podivilov]

(In reply to comment #8)
> (From update of attachment 97268 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97268&action=review
> 
> > Source/WebCore/inspector/front-end/inspector.js:1281
> > +    // FIXME: stack trace line/column numbers are one-based.
> 
> Please file a bug on this.

https://bugs.webkit.org/show_bug.cgi?id=62725.