RESOLVED DUPLICATE of bug 6231962279
[Skia] check for null-shader from gradient factory 
https://bugs.webkit.org/show_bug.cgi?id=62279
Summary [Skia] check for null-shader from gradient factory
Mike Reed
Reported 2011-06-08 07:07:34 PDT
check for null-shader from gradient factory
Attachments
Patch (1.88 KB, patch)
2011-06-08 07:08 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (3.35 KB, patch)
2011-06-08 11:59 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Patch (3.24 KB, patch)
2011-06-08 12:00 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-06-08 07:08:48 PDT
Created attachment 96415 [details] Patch
James Robinson
Comment 2 2011-06-08 09:13:41 PDT
Comment on attachment 96415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96415&action=review We need test coverage for the degenerate case if that's causing the crash. > Source/WebCore/ChangeLog:8 > + No new tests. existing tests exercise the gradient code-path What existing test covers this codepath? I would expect one of our current tests to be crashing without this patch if we had test coverage.... > Source/WebCore/platform/graphics/skia/GradientSkia.cpp:175 > + // if we got no gradient, the the colors must be degenerate, so nitpick: Capitalize "if", typo "the the"
Mike Reed
Comment 3 2011-06-08 11:59:08 PDT
Created attachment 96448 [details] Patch
Mike Reed
Comment 4 2011-06-08 12:00:38 PDT
Created attachment 96449 [details] Patch
Mike Reed
Comment 5 2011-06-08 12:01:55 PDT
added new test-case remove obsolete range checks on m_r1 for radial gradients
Mike Reed
Comment 6 2011-06-08 14:21:59 PDT
*** This bug has been marked as a duplicate of bug 62319 ***
James Robinson
Comment 7 2011-06-08 21:22:33 PDT
Comment on attachment 96449 [details] Patch Clearing bits, a fix for this landed on https://bugs.webkit.org/show_bug.cgi?id=62319
Note You need to log in before you can comment on or make changes to this bug.