WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62263
[Chromium] Add stubs to WebWidget
https://bugs.webkit.org/show_bug.cgi?id=62263
Summary
[Chromium] Add stubs to WebWidget
Sailesh Agrawal
Reported
2011-06-07 22:02:29 PDT
Remove stubs for WebWidget::willStartLiveResize and WebWidget::willEndLiveResize
Attachments
Patch
(1.78 KB, patch)
2011-06-07 22:03 PDT
,
Sailesh Agrawal
no flags
Details
Formatted Diff
Diff
Patch
(8.34 KB, patch)
2011-06-08 20:55 PDT
,
Sailesh Agrawal
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sailesh Agrawal
Comment 1
2011-06-07 22:03:25 PDT
Created
attachment 96379
[details]
Patch
Sailesh Agrawal
Comment 2
2011-06-07 22:04:02 PDT
Waiting for Chromium try bots to complete before asking for review.
Sailesh Agrawal
Comment 3
2011-06-08 10:20:42 PDT
Try bots passed.
Darin Fisher (:fishd, Google)
Comment 4
2011-06-08 16:39:27 PDT
Comment on
attachment 96379
[details]
Patch I think a better fix would be to make all of the methods have default implementations since there is an implementation of WebWidget in the Chromium repository. If you don't do that then we will continually have to repeat this exercise. It would be better if the code guided people to add default implementations (which is what we do for other interfaces that Chromium implements -- e.g., WebFrameClient).
Sailesh Agrawal
Comment 5
2011-06-08 20:55:18 PDT
Created
attachment 96539
[details]
Patch
Sailesh Agrawal
Comment 6
2011-06-08 20:56:43 PDT
Default implementations added for all methods in WebWidget.
Darin Fisher (:fishd, Google)
Comment 7
2011-06-08 21:56:38 PDT
Comment on
attachment 96539
[details]
Patch Thanks! R+CQ=me
WebKit Review Bot
Comment 8
2011-06-08 22:35:32 PDT
Comment on
attachment 96539
[details]
Patch Clearing flags on attachment: 96539 Committed
r88422
: <
http://trac.webkit.org/changeset/88422
>
WebKit Review Bot
Comment 9
2011-06-08 22:35:36 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug