Bug 62258 - (CG) Sub-image drawing clips unnecessarily
Summary: (CG) Sub-image drawing clips unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-07 19:30 PDT by Ian Henderson
Modified: 2011-06-07 22:33 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.41 KB, patch)
2011-06-07 20:06 PDT, Ian Henderson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Henderson 2011-06-07 19:30:36 PDT 
When drawing sub-images in BitmapImage::draw, we clip to destRect, then draw into adjustedDestRect.  If they're the same, we could avoid clipping and just draw the image.
Comment 1 Ian Henderson 2011-06-07 19:31:54 PDT 
rdar://problem/9567167
Comment 2 Ian Henderson 2011-06-07 20:06:52 PDT 
Created attachment 96366 [details]
proposed patch
Comment 3 WebKit Review Bot 2011-06-07 20:31:38 PDT 
Comment on attachment 96366 [details]
proposed patch

Clearing flags on attachment: 96366

Committed r88321: <http://trac.webkit.org/changeset/88321>
Comment 4 WebKit Review Bot 2011-06-07 20:31:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 James Kozianski 2011-06-07 22:33:06 PDT 
I think this caused some pixel changes for SnowLeopard. The changes seemed fine to me so I commit them in r88325 if you wanted to verify.