Bug 62239 – V8NodeFilterCondition should use OwnHandle

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Adam Barth]

V8NodeFilterCondition should use OwnHandle

[Adam Barth]

Created attachment 96313 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 96313 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review

> Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63
> +    if (!m_filter.get()->IsObject())

Why don't we override -> on OwnHandle like we do for our other smartpointers?

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 96313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96313&action=review
> 
> > Source/WebCore/bindings/v8/V8NodeFilterCondition.cpp:63
> > +    if (!m_filter.get()->IsObject())
> 
> Why don't we override -> on OwnHandle like we do for our other smartpointers?

We could.  It's a little confusing because v8::Handle has a bunch of APIs that you access with "." that are useful too.

[Adam Barth]

Adding some potential reviewers.

[Adam Barth]

Thank you sir.

[WebKit Review Bot]

Comment on attachment 96313 [details]
Patch

Rejecting attachment 96313 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>)
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Proxy.o
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8Utilities.o
make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/8833496

[Adam Barth]

Created attachment 98216 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 98216 [details]
Patch for landing

Rejecting attachment 98216 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
lHandle(WebCore::V8NodeFilterCondition* const, v8::Handle<v8::Value>)'
Source/WebCore/bindings/v8/V8GCController.h:72: note: candidates are: static void WebCore::V8GCController::unregisterGlobalHandle(void*, v8::Persistent<v8::Value>)
  CXX(target) out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/custom/V8WebKitAnimationCustom.o
make: *** [out/Debug/obj.target/webcore_remaining/Source/WebCore/bindings/v8/V8NodeFilterCondition.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/8921858