Bug 62229 – Fix "branding" issue in features.gypi

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Fix "branding" issue in features.gypi

[Adam Barth]

Created attachment 96295 [details]
Patch

[Tony Chang]

Comment on attachment 96295 [details]
Patch

Ah, I see, it was because of nesting.

[Adam Barth]

I don't fully understanding the nesting stuff.  I don't have a good mental model for what it does.

[Adam Barth]

Comment on attachment 96295 [details]
Patch

Clearing flags on attachment: 96295

Committed r88268: <http://trac.webkit.org/changeset/88268>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.

[Tony Chang]

(In reply to comment #3)
> I don't fully understanding the nesting stuff.  I don't have a good mental model for what it does.

I don't know why there are so many levels of nesting in feature_overrides.gypi.  It's probably not necessary.

Normally, we use nesting for using a variable in a condition.

For example,

'variables': {
  'foo': 0,
  'conditions': {
    # Can't use foo, not defined in this scope.
  }
},

To work around this, you nest variables.

'variables': {
  'variables': {
    'foo': 0
  },
  'conditions': [
    # Can use foo.
  ]
}

In build/common.gypi, this is because we have variable values that depend on other variable values.  Like:

'variables': {
  'variables': {
    'chromeos': 0
  },
  'conditions': [
    [ 'chromeos==1', {
      'toolkit_views': 1,
    }, {
      'toolkit_views': 0
    }]
  ]
}

[Adam Barth]

I fail at changing this file.  I'm going to back everything out and try again another day.