RESOLVED FIXED 62223
Use correct CFURLStorageSessionRef definition on Snow Leopard 
https://bugs.webkit.org/show_bug.cgi?id=62223
Summary Use correct CFURLStorageSessionRef definition on Snow Leopard
Tim Horton
Reported 2011-06-07 11:52:47 PDT
Patch forthcoming.
Attachments
Use correct CFURLStorageSessionRef definition on Snow Leopard (3.70 KB, patch)
2011-06-07 12:00 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Use correct CFURLStorageSessionRef definition on Snow Leopard (3.89 KB, patch)
2011-06-07 12:03 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Use correct CFURLStorageSessionRef definition on Snow Leopard (3.74 KB, patch)
2011-06-07 12:12 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Define CFURLStorageSessionRef correctly on all platforms (5.07 KB, patch)
2011-06-07 15:23 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Fix CFURLStorageSessionRef build problem on Leopard (2.93 KB, patch)
2011-06-08 12:15 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2011-06-07 12:00:42 PDT
Created attachment 96274 [details] Use correct CFURLStorageSessionRef definition on Snow Leopard
Tim Horton
Comment 2 2011-06-07 12:03:53 PDT
Created attachment 96277 [details] Use correct CFURLStorageSessionRef definition on Snow Leopard
Tim Horton
Comment 3 2011-06-07 12:12:04 PDT
Created attachment 96279 [details] Use correct CFURLStorageSessionRef definition on Snow Leopard
WebKit Review Bot
Comment 4 2011-06-07 13:37:40 PDT
Comment on attachment 96279 [details] Use correct CFURLStorageSessionRef definition on Snow Leopard Clearing flags on attachment: 96279 Committed r88259: <http://trac.webkit.org/changeset/88259>
WebKit Review Bot
Comment 5 2011-06-07 13:37:45 PDT
All reviewed patches have been landed. Closing bug.
Adele Peterson
Comment 6 2011-06-07 15:21:32 PDT
It looks like this got rolled out due to build breakage. https://bugs.webkit.org/show_bug.cgi?id=62228
Tim Horton
Comment 7 2011-06-07 15:23:16 PDT
Created attachment 96311 [details] Define CFURLStorageSessionRef correctly on all platforms
Adele Peterson
Comment 8 2011-06-07 15:25:15 PDT
Reopening.
Jessie Berlin
Comment 9 2011-06-07 15:43:34 PDT
Comment on attachment 96311 [details] Define CFURLStorageSessionRef correctly on all platforms Unofficial r=me! (I am not yet a reviewer)
WebKit Review Bot
Comment 10 2011-06-07 19:14:13 PDT
Comment on attachment 96311 [details] Define CFURLStorageSessionRef correctly on all platforms Clearing flags on attachment: 96311 Committed r88316: <http://trac.webkit.org/changeset/88316>
WebKit Review Bot
Comment 11 2011-06-07 19:14:18 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 12 2011-06-08 11:52:54 PDT
Leopard bot is still failing to build :( http://build.webkit.org/waterfall?show=Leopard%20Intel%20Release%20(Build) http://build.webkit.org/builders/Leopard%20Intel%20Release%20%28Build%29/builds/35536/steps/compile-webkit/logs/stdio In file included from /Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/accessibility/mac/AccessibilityObjectWrapper.mm:67: /Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/mac/WebCoreSystemInterface.h:285: error: conflicting declaration 'typedef struct __CFURLStorageSession* CFURLStorageSessionRef' /Volumes/Big/WebKit-BuildSlave/leopard-intel-release/build/Source/WebCore/platform/network/cf/ResourceRequest.h:46: error: 'CFURLStorageSessionRef' has a previous declaration as 'typedef const struct __CFURLStorageSession* CFURLStorageSessionRef' Could you take a look?
Tim Horton
Comment 13 2011-06-08 12:11:39 PDT
Oop, you're right. That's the one direction I can't test in at the moment. Patch in a moment.
Tim Horton
Comment 14 2011-06-08 12:15:53 PDT
Created attachment 96456 [details] Fix CFURLStorageSessionRef build problem on Leopard Hopefully this is the end of this one.
Ryosuke Niwa
Comment 15 2011-06-08 12:21:31 PDT
Comment on attachment 96456 [details] Fix CFURLStorageSessionRef build problem on Leopard looks sane to me.
WebKit Review Bot
Comment 16 2011-06-08 15:38:59 PDT
Comment on attachment 96456 [details] Fix CFURLStorageSessionRef build problem on Leopard Clearing flags on attachment: 96456 Committed r88398: <http://trac.webkit.org/changeset/88398>
WebKit Review Bot
Comment 17 2011-06-08 15:39:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.