Bug 62207 - [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style
Summary: [Qt] RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 52920 62208
  Show dependency treegraph
 
Reported: 2011-06-07 06:32 PDT by Kent Tamura
Modified: 2011-06-07 17:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.20 KB, patch)
2011-06-07 07:17 PDT, Kent Tamura
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-06-07 06:32:15 PDT
RenderThemeQt::adjustSliderThumbSize() should not refer to the parent style.
Comment 1 Kent Tamura 2011-06-07 07:17:12 PDT
Created attachment 96241 [details]
Patch
Comment 2 Andreas Kling 2011-06-07 15:41:08 PDT
Comment on attachment 96241 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96241&action=review

Thanks for lookin' out for Qt! <3
r=me

> Source/WebCore/ChangeLog:13
> +        * platform/qt/RenderThemeQt.cpp: Use fixed values to avoid to refer to o->parent().

to refer -> referring

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1468
> +    // timelineThumbHeight should match to the height property of -webkit-media-controls-timeline in mediaControlsQt.css.

match to -> match

> Source/WebCore/platform/qt/RenderThemeQt.cpp:1471
> +    // volumeThmbWidth should match to the width property of -webkit-media-controls-volue-slider in mediaControlsQt.css.

match to -> match
volumeThmbWidth -> volumeThumbWidth
volue -> volume
Comment 3 Kent Tamura 2011-06-07 17:18:33 PDT
(In reply to comment #2)

Thank you for reviewing!

I'll land with these English corrections.
Comment 4 Kent Tamura 2011-06-07 17:26:24 PDT
Committed r88294: <http://trac.webkit.org/changeset/88294>