RESOLVED FIXED 62206
Web Inspector: remove duplicate breakpoints from localStorage 
https://bugs.webkit.org/show_bug.cgi?id=62206
Summary Web Inspector: remove duplicate breakpoints from localStorage
Yury Semikhatsky
Reported 2011-06-07 06:20:45 PDT
There was a bug that caused breakpoints duplication(see e.g. this Chromium report: http://crbug.com/85029). This may have caused breakpoint storage growth up to several megabytes which significantly slows down breakpoint operations. To overcome this we need to perform one-time settings normalization.
Attachments
Patch (4.01 KB, patch)
2011-06-07 06:36 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2011-06-07 07:51 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-06-07 06:36:14 PDT
Created attachment 96236 [details] Patch
Pavel Feldman
Comment 2 2011-06-07 07:44:54 PDT
Comment on attachment 96236 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96236&action=review > Source/WebCore/inspector/front-end/Settings.js:127 > + var start = s.indexOf("{", i); Seems like a weak assumption. Should we nuke it altogether?
Yury Semikhatsky
Comment 3 2011-06-07 07:51:30 PDT
Created attachment 96245 [details] Patch
Yury Semikhatsky
Comment 4 2011-06-07 07:54:22 PDT
(In reply to comment #3) > Created an attachment (id=96245) [details] > Patch As discussed offline the normalization logic looks overcomplicated. Instead of that we will simply clear breakpoint storage once.
Yury Semikhatsky
Comment 5 2011-06-07 08:19:27 PDT
Committed r88237: <http://trac.webkit.org/changeset/88237>
Note You need to log in before you can comment on or make changes to this bug.