Bug 62185 - Clean up ContentData
: Clean up ContentData
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-06-06 22:15 PST by
Modified: 2011-06-07 15:15 PST (History)


Attachments
Patch (28.04 KB, patch)
2011-06-07 13:44 PST, Simon Fraser (smfr)
hyatt: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-06-06 22:15:09 PST
ContentData is pretty heinous:
* It uses manual refcounting of images and strings
* deleteContent() leaves stale pointers around
* It's not copyable
------- Comment #1 From 2011-06-07 13:44:49 PST -------
Created an attachment (id=96293) [details]
Patch
------- Comment #2 From 2011-06-07 13:48:51 PST -------
(From update of attachment 96293 [details])
r=me
------- Comment #3 From 2011-06-07 15:15:20 PST -------
http://trac.webkit.org/changeset/88270