Bug 62185 - Clean up ContentData
: Clean up ContentData
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Simon Fraser (smfr)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-06 22:15 PDT by Simon Fraser (smfr)
Modified: 2011-06-07 15:15 PDT (History)
1 user (show)

See Also:


Attachments
Patch (28.04 KB, patch)
2011-06-07 13:44 PDT, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-06-06 22:15:09 PDT
ContentData is pretty heinous:
* It uses manual refcounting of images and strings
* deleteContent() leaves stale pointers around
* It's not copyable
Comment 1 Simon Fraser (smfr) 2011-06-07 13:44:49 PDT
Created attachment 96293 [details]
Patch
Comment 2 Dave Hyatt 2011-06-07 13:48:51 PDT
Comment on attachment 96293 [details]
Patch

r=me
Comment 3 Simon Fraser (smfr) 2011-06-07 15:15:20 PDT
http://trac.webkit.org/changeset/88270