Bug 62176 - Change RenderBlock::hitTestFloats to IntPoint
Summary: Change RenderBlock::hitTestFloats to IntPoint
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
Depends on:
Blocks: 60318
  Show dependency treegraph
Reported: 2011-06-06 19:02 PDT by Emil A Eklund
Modified: 2011-06-07 19:32 PDT (History)
4 users (show)

See Also:

Patch (4.89 KB, patch)
2011-06-06 19:05 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (4.85 KB, patch)
2011-06-07 16:23 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-06-06 19:02:52 PDT
Ongoing tx, ty removal.
Comment 1 Emil A Eklund 2011-06-06 19:05:47 PDT
Created attachment 96175 [details]
Comment 2 Emil A Eklund 2011-06-07 14:49:22 PDT
Eric, did you miss this one in the flood of bug mail?
Comment 3 Eric Seidel (no email) 2011-06-07 14:56:13 PDT
Comment on attachment 96175 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=96175&action=review

> Source/WebCore/rendering/RenderBlock.cpp:3964
> +        adjustedLocation += IntSize(toRenderView(this)->frameView()->scrollX(), toRenderView(this)->frameView()->scrollY());

Should we be using a scrollLocation() function here?
Comment 4 Emil A Eklund 2011-06-07 14:56:32 PDT
Arhh, got the name wrong. This is about hitTestFloats. Not Columns.
Comment 5 Emil A Eklund 2011-06-07 16:23:35 PDT
Created attachment 96323 [details]
Patch for landing
Comment 6 Emil A Eklund 2011-06-07 19:32:55 PDT
Landed r88317.