Bug 62172 – Change RenderBlock::hitTestColumns to IntPoint

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Emil A Eklund]

Ongoing tx, ty removal.

[Emil A Eklund]

Created attachment 96167 [details]
Patch

[Emil A Eklund]

This will make more sense when 62170 is in. I plan to rename accumulatedOffset before committing, assuming we agree on a name name before then.

[Eric Seidel (no email)]

Comment on attachment 96167 [details]
Patch

OK.

[Eric Seidel (no email)]

Comment on attachment 96167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96167&action=review

> Source/WebCore/rendering/RenderBlock.cpp:4025
> +                return hitTestContents(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y(), hitTestAction) || (hitTestAction == HitTestFloat && hitTestFloats(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y()));

adjusted position is also a meaningless name IMO.

[Emil A Eklund]

Created attachment 96300 [details]
Patch for landing

[Emil A Eklund]

Renamed adjustedPosition to finalLocation to mirror the name used previously.

[WebKit Review Bot]

Comment on attachment 96300 [details]
Patch for landing

Rejecting attachment 96300 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
rce/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderBlock.cpp
Hunk #3 FAILED at 4010.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej
patching file Source/WebCore/rendering/RenderBlock.h
Hunk #1 FAILED at 588.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8812100

[Emil A Eklund]

Landed r88311.