Bug 62172 - Change RenderBlock::hitTestColumns to IntPoint
Summary: Change RenderBlock::hitTestColumns to IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency treegraph
 
Reported: 2011-06-06 18:01 PDT by Emil A Eklund
Modified: 2011-06-07 18:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.66 KB, patch)
2011-06-06 18:07 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff
Patch for landing (4.62 KB, patch)
2011-06-07 14:44 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-06-06 18:01:54 PDT
Ongoing tx, ty removal.
Comment 1 Emil A Eklund 2011-06-06 18:07:45 PDT
Created attachment 96167 [details]
Patch
Comment 2 Emil A Eklund 2011-06-06 18:09:07 PDT
This will make more sense when 62170 is in. I plan to rename accumulatedOffset before committing, assuming we agree on a name name before then.
Comment 3 Eric Seidel (no email) 2011-06-07 10:49:02 PDT
Comment on attachment 96167 [details]
Patch

OK.
Comment 4 Eric Seidel (no email) 2011-06-07 10:49:26 PDT
Comment on attachment 96167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96167&action=review

> Source/WebCore/rendering/RenderBlock.cpp:4025
> +                return hitTestContents(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y(), hitTestAction) || (hitTestAction == HitTestFloat && hitTestFloats(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y()));

adjusted position is also a meaningless name IMO.
Comment 5 Emil A Eklund 2011-06-07 14:44:42 PDT
Created attachment 96300 [details]
Patch for landing
Comment 6 Emil A Eklund 2011-06-07 14:48:28 PDT
Renamed adjustedPosition to finalLocation to mirror the name used previously.
Comment 7 WebKit Review Bot 2011-06-07 17:58:30 PDT
Comment on attachment 96300 [details]
Patch for landing

Rejecting attachment 96300 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
rce/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/rendering/RenderBlock.cpp
Hunk #3 FAILED at 4010.
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej
patching file Source/WebCore/rendering/RenderBlock.h
Hunk #1 FAILED at 588.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8812100
Comment 8 Emil A Eklund 2011-06-07 18:46:55 PDT
Landed r88311.