WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
62172
Change RenderBlock::hitTestColumns to IntPoint
https://bugs.webkit.org/show_bug.cgi?id=62172
Summary
Change RenderBlock::hitTestColumns to IntPoint
Emil A Eklund
Reported
2011-06-06 18:01:54 PDT
Ongoing tx, ty removal.
Attachments
Patch
(4.66 KB, patch)
2011-06-06 18:07 PDT
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
Patch for landing
(4.62 KB, patch)
2011-06-07 14:44 PDT
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Emil A Eklund
Comment 1
2011-06-06 18:07:45 PDT
Created
attachment 96167
[details]
Patch
Emil A Eklund
Comment 2
2011-06-06 18:09:07 PDT
This will make more sense when 62170 is in. I plan to rename accumulatedOffset before committing, assuming we agree on a name name before then.
Eric Seidel (no email)
Comment 3
2011-06-07 10:49:02 PDT
Comment on
attachment 96167
[details]
Patch OK.
Eric Seidel (no email)
Comment 4
2011-06-07 10:49:26 PDT
Comment on
attachment 96167
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=96167&action=review
> Source/WebCore/rendering/RenderBlock.cpp:4025 > + return hitTestContents(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y(), hitTestAction) || (hitTestAction == HitTestFloat && hitTestFloats(request, result, pointInContainer, adjustedPosition.x(), adjustedPosition.y()));
adjusted position is also a meaningless name IMO.
Emil A Eklund
Comment 5
2011-06-07 14:44:42 PDT
Created
attachment 96300
[details]
Patch for landing
Emil A Eklund
Comment 6
2011-06-07 14:48:28 PDT
Renamed adjustedPosition to finalLocation to mirror the name used previously.
WebKit Review Bot
Comment 7
2011-06-07 17:58:30 PDT
Comment on
attachment 96300
[details]
Patch for landing Rejecting
attachment 96300
[details]
from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: rce/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderBlock.cpp Hunk #3 FAILED at 4010. 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.cpp.rej patching file Source/WebCore/rendering/RenderBlock.h Hunk #1 FAILED at 588. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBlock.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output:
http://queues.webkit.org/results/8812100
Emil A Eklund
Comment 8
2011-06-07 18:46:55 PDT
Landed
r88311
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug