Bug 62156 - Switch InlineFlowBox::paintMask to use IntPoint
Summary: Switch InlineFlowBox::paintMask to use IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-06-06 15:14 PDT by Levi Weintraub
Modified: 2011-06-06 15:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2011-06-06 15:18 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-06 15:14:53 PDT 
Ongoing tx/ty removal.
Comment 1 Levi Weintraub 2011-06-06 15:18:13 PDT 
Created attachment 96138 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-06 15:23:26 PDT 
Comment on attachment 96138 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96138&action=review

> Source/WebCore/rendering/InlineFlowBox.cpp:1223
> +        int stripX = adjustedPaintOffset.x() - (isHorizontal() ? logicalOffsetOnLine : 0);
> +        int stripY = adjustedPaintOffset.y() - (isHorizontal() ? 0 : logicalOffsetOnLine);
>          int stripWidth = isHorizontal() ? totalLogicalWidth : frameRect.width();
>          int stripHeight = isHorizontal() ? frameRect.height() : totalLogicalWidth;

I suspect we can clean this up more in a later pass.
Comment 3 Levi Weintraub 2011-06-06 15:27:23 PDT 
Comment on attachment 96138 [details]
Patch

Clearing flags on attachment: 96138

Committed r88196: <http://trac.webkit.org/changeset/88196>
Comment 4 Levi Weintraub 2011-06-06 15:27:26 PDT 
All reviewed patches have been landed.  Closing bug.