RESOLVED FIXED 62156
Switch InlineFlowBox::paintMask to use IntPoint 
https://bugs.webkit.org/show_bug.cgi?id=62156
Summary Switch InlineFlowBox::paintMask to use IntPoint
Levi Weintraub
Reported 2011-06-06 15:14:53 PDT
Ongoing tx/ty removal.
Attachments
Patch (4.99 KB, patch)
2011-06-06 15:18 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-06-06 15:18:13 PDT
Created attachment 96138 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-06 15:23:26 PDT
Comment on attachment 96138 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96138&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:1223 > + int stripX = adjustedPaintOffset.x() - (isHorizontal() ? logicalOffsetOnLine : 0); > + int stripY = adjustedPaintOffset.y() - (isHorizontal() ? 0 : logicalOffsetOnLine); > int stripWidth = isHorizontal() ? totalLogicalWidth : frameRect.width(); > int stripHeight = isHorizontal() ? frameRect.height() : totalLogicalWidth; I suspect we can clean this up more in a later pass.
Levi Weintraub
Comment 3 2011-06-06 15:27:23 PDT
Comment on attachment 96138 [details] Patch Clearing flags on attachment: 96138 Committed r88196: <http://trac.webkit.org/changeset/88196>
Levi Weintraub
Comment 4 2011-06-06 15:27:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.