Bug 62133 - Convert RenderBox::pushContentsClip to IntPoint
Summary: Convert RenderBox::pushContentsClip to IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks: 60318 62140
  Show dependency tree / graph
 
Reported: 2011-06-06 10:59 PDT by Emil A Eklund
Modified: 2011-06-06 16:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.96 KB, patch)
2011-06-06 12:48 PDT, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-06-06 10:59:17 PDT 
Ongoing tx, ty removal.
Comment 1 Emil A Eklund 2011-06-06 12:48:16 PDT 
Created attachment 96110 [details]
Patch
Comment 2 WebKit Commit Bot 2011-06-06 15:08:01 PDT 
The commit-queue encountered the following flaky tests while processing attachment 96110 [details]:

media/video-currentTime-set.html bug 62154 (authors: annacc@chromium.org, jamesr@chromium.org, pnormand@igalia.com, and vrk@chromium.org)
http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 3 WebKit Commit Bot 2011-06-06 15:09:02 PDT 
Comment on attachment 96110 [details]
Patch

Rejecting attachment 96110 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'land-a..." exit_code: 2

Last 500 characters of output:
ource/WebCore/rendering/RenderListBox.cpp
r88193 = c097f47edbacae18f2bf84fccb808dbe2304b2ff (refs/remotes/trunk)
	A	LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.png
	A	LayoutTests/platform/chromium-win/fast/inline/inline-wrap-with-parent-padding-expected.txt
	M	LayoutTests/ChangeLog
r88194 = 58e12fd9578b5b8483300ca23171b25471a16c04 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8788008
Comment 4 WebKit Review Bot 2011-06-06 15:14:20 PDT 
Comment on attachment 96110 [details]
Patch

Rejecting attachment 96110 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
nderBox.cpp
patching file Source/WebCore/rendering/RenderBox.h
Hunk #1 FAILED at 349.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderBox.h.rej
patching file Source/WebCore/rendering/RenderTable.cpp
Hunk #1 succeeded at 467 with fuzz 1.
patching file Source/WebCore/rendering/RenderTableSection.cpp
Hunk #1 succeeded at 903 with fuzz 1.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8770493
Comment 5 Emil A Eklund 2011-06-06 16:04:49 PDT 
Landed as revision 88198.