RESOLVED FIXED62122
window.onerror broke m.facebook.com 
https://bugs.webkit.org/show_bug.cgi?id=62122
Summary window.onerror broke m.facebook.com
Krzysztof Czech
Reported 2011-06-06 05:45:37 PDT
I found a problem on http://m.facebook.com site. Generally problem occurs on registration form when one of the select controls with date is clicked. It could be either "year", "month" or "day" control. Browser shows an error page with "Connection error" message. Accordingly WebCore reports an exception with an error message, "Can't find variable: bagofholding". It looks like "bugofholding" might be some javascript. Unfortunately it could not be found. Basically, the situation with error page happens with this commit "c8a06eb946ed0cbe5c144daa894c1fdb5d9f190a". Precisely in ScriptExecutionContext::reportException method, as soon as execution flow reaches dispatchErrorEvent method.
Attachments
Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-06-06 06:55:19 PDT
Looks like the problem is in the site which sets error handler using window.onerror = ... and the handler is invoked for "Uncaught ReferenceError: bagofholding is not defined" which is expected behavior of window.onerror. Before the change you mentioned window.onerror didn't work in WebKit and no uncaught exceptions would reach window.onerror handler.
Alexey Proskuryakov
Comment 2 2011-06-06 14:14:39 PDT
<rdar://problem/9560131>
Alexey Proskuryakov
Comment 3 2011-10-27 08:53:41 PDT
I'm told that Facebook fixed this.
Note You need to log in before you can comment on or make changes to this bug.