Bug 62094 - [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
Summary: [Mac WebKit2] REGRESSION (r86692): Synchronous XMLHttpRequest hangs in creden...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 12:26 PDT by Darin Adler
Modified: 2011-06-04 14:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch (24.45 KB, patch)
2011-06-04 12:30 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (24.80 KB, patch)
2011-06-04 13:16 PDT, Darin Adler 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-06-04 12:26:35 PDT 
REGRESSION (r86692): Synchronous XMLHttpRequest hangs in credential shim (affects Netgear ReadyNAS admin page)
Comment 1 Darin Adler 2011-06-04 12:30:40 PDT 
Created attachment 96030 [details]
Patch
Comment 2 Anders Carlsson 2011-06-04 12:37:14 PDT 
Comment on attachment 96030 [details]
Patch

I don't think CoreIPCThread is a good name, it might be mistaken for the CoreIPC work queue that sends/receives message.

a CoreIPC connection has the notion of a "client run loop" where incoming messages will be dispatched. Maybe callOnCoreIPCClientRunLoopAndWait is a better name.
Comment 3 Darin Adler 2011-06-04 12:48:00 PDT 
(In reply to comment #2)
> Maybe callOnCoreIPCClientRunLoopAndWait is a better name.

Sure thing; I’ll change to that name.

Any ideas for better names for the source files CoreIPCThread.h/mm?
Comment 4 Darin Adler 2011-06-04 13:16:13 PDT 
Created attachment 96031 [details]
Patch
Comment 5 Darin Adler 2011-06-04 14:03:35 PDT 
Committed r88123: <http://trac.webkit.org/changeset/88123>
Comment 6 Darin Adler 2011-06-04 14:04:03 PDT 
Comment on attachment 96031 [details]
Patch

The patch I landed also included a FIXME comment explaining we could do this with work items instead.