Bug 62090 - [GTK] Webkit does not check if windows are X11 windows before calling gtk_window_*
Summary: [GTK] Webkit does not check if windows are X11 windows before calling gtk_win...
Status: RESOLVED DUPLICATE of bug 76911
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-04 06:20 PDT by Jérôme Guelfucci
Modified: 2013-01-30 08:57 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jérôme Guelfucci 2011-06-04 06:20:41 PDT 
Hello,

When using a WebkitWebView in a GtkOffscreenWindow, the code in ChromeClient::windowRect and ChromeClient::setWindowRect is not valid because the GtkOffscreenWindow will be a toplevel widget but you still can't call gtk_window_* functions on it. This could explain the crashes I often get on page rendering.

This happens with WebKitGtk 1.2.7 in Debian testing. I'm willing to test patches if needed.

Cheers,

Jérôme
Comment 1 Martin Robinson 2011-06-04 20:38:59 PDT 
Is it possible for you to verify this is still an issue with the 1.4.0 or development releases?
Comment 2 Jérôme Guelfucci 2011-06-05 00:00:28 PDT 
I can't test with those versions but reading the code of 1.4.0, I still see gtk_window_* usage without any other check than gtk_widget_is_toplevel () in ChromeClientGtk.cpp.
Comment 3 Eduardo Lima Mitev 2013-01-30 08:26:58 PST 
I tested WebKitGTK 1.11.4 (trunk from Jan 29th, 2013) with GTK offscreen windows and it seems to be working fine.

Looking at ChromeClientGtk.cpp there are checks for the presence of onscreen window (through widgetIsOnscreenToplevelWindow()) before all calls to gtk_window_*. So, so this bug no longer holds and I think it can be closed as already fixed. Though, I wonder if we need to add a test that verifies sanity with GTK offscreen windows.
Comment 4 Martin Robinson 2013-01-30 08:57:29 PST 
I'm pretty sure we can close this.

*** This bug has been marked as a duplicate of bug 76911 ***