Bug 62089 - [Qt] Fix and unskip acid2
Summary: [Qt] Fix and unskip acid2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords: LayoutTestFailure, Qt, QtTriaged
Depends on:
Blocks: 62108
  Show dependency tree / graph
 
Reported: 2011-06-04 05:08 PDT by Robert Hogan
Modified: 2011-06-05 13:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (28.95 KB, patch)
2011-06-04 05:20 PDT, Robert Hogan 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2011-06-04 05:08:31 PDT 
[Qt] Fix and unskip acid2
Comment 1 Robert Hogan 2011-06-04 05:20:20 PDT 
Created attachment 96019 [details]
Patch
Comment 2 Benjamin Poulain 2011-06-04 06:29:44 PDT 
Adding Andreas, he knows the frame loader a lot better than I do.
Comment 3 Andreas Kling 2011-06-04 07:06:41 PDT 
Comment on attachment 96019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96019&action=review

Looks good, r=me.

> Source/WebKit/qt/ChangeLog:18
> +        Some ports also check when WebKitErrorPluginWillHandleLoad deciding
> +        what to return. This error isn't currently set by Qt so we don't check

This looks a bit jumbled.
Some ports also check WebKitErrorPluginWillHandleLoad when deciding what to return?

> Source/WebKit/qt/ChangeLog:20
> +        it. (Other ports set it when the erring document is a MediaDocument, maybe
> +        we should do that too at some point).

Sounds like you should file a bug about that. :)
Comment 4 Robert Hogan 2011-06-05 13:13:09 PDT 
Committed r88135: <http://trac.webkit.org/changeset/88135>