Bug 62084 - clang build error: hidden overloaded virtual function
Summary: clang build error: hidden overloaded virtual function
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-06-03 21:50 PDT by Joseph Pecoraro
Modified: 2011-06-03 22:03 PDT (History)
2 users (show)

See Also:

[PATCH] Build Fix (2.42 KB, patch)
2011-06-03 22:01 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-06-03 21:50:21 PDT
This seemed to cause a clang build warning (which is treated as an error).

> CompileC RenderTable.o
> In file included from /Users/pecoraro/Code/webkit-open-source/Source/WebCore/rendering/RenderTable.cpp:38:
> Source/WebCore/rendering/RenderTableCell.h:146:18: error: 'WebCore::RenderTableCell::paintMask' hides overloaded virtual function [-Werror,-Woverloaded-virtual,3]
> Source/WebCore/rendering/RenderBox.h:357:18: note: hidden overloaded virtual function 'WebCore::RenderBox::paintMask' declared here [3]
> 1 error generated.
> Command /Developer/usr/bin/clang failed with exit code 1

Indeed the functions have a similar but different signature:

  virtual void paintMask(PaintInfo&, const IntPoint&);

  virtual void paintMask(PaintInfo&, IntSize);

RenderTableCell just takes the incoming IntSize and makes an IntPoint out of it anyways.
Comment 1 Joseph Pecoraro 2011-06-03 21:51:10 PDT
I meant to say this was caused by:

But we should probably just fix RenderTableCell.
Comment 2 Joseph Pecoraro 2011-06-03 22:01:02 PDT
Created attachment 96007 [details]
[PATCH] Build Fix

I just want a sanity check from someone on this one, but I'm pretty sure its the right fix.
Comment 3 Joseph Pecoraro 2011-06-03 22:03:18 PDT
Mitz "The Master" landed this already in: