Bug 62084 – clang build error: hidden overloaded virtual function

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

This seemed to cause a clang build warning (which is treated as an error).

> CompileC RenderTable.o
> In file included from /Users/pecoraro/Code/webkit-open-source/Source/WebCore/rendering/RenderTable.cpp:38:
> Source/WebCore/rendering/RenderTableCell.h:146:18: error: 'WebCore::RenderTableCell::paintMask' hides overloaded virtual function [-Werror,-Woverloaded-virtual,3]
> Source/WebCore/rendering/RenderBox.h:357:18: note: hidden overloaded virtual function 'WebCore::RenderBox::paintMask' declared here [3]
> 1 error generated.
> Command /Developer/usr/bin/clang failed with exit code 1

Indeed the functions have a similar but different signature:

  RenderBox.h:
  virtual void paintMask(PaintInfo&, const IntPoint&);

  RenderTableCell.h:
  virtual void paintMask(PaintInfo&, IntSize);

RenderTableCell just takes the incoming IntSize and makes an IntPoint out of it anyways.

[Joseph Pecoraro]

I meant to say this was caused by:
<http://trac.webkit.org/changeset/88087>

But we should probably just fix RenderTableCell.

[Joseph Pecoraro]

Created attachment 96007 [details]
[PATCH] Build Fix

I just want a sanity check from someone on this one, but I'm pretty sure its the right fix.

[Joseph Pecoraro]

Mitz "The Master" landed this already in:
<http://trac.webkit.org/changeset/88090>