Bug 62072 - [chromium] Make PlatformMessagePortChannel's destructor virtual
Summary: [chromium] Make PlatformMessagePortChannel's destructor virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 17:08 PDT by Nico Weber
Modified: 2011-06-04 03:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2011-06-03 17:09 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-06-03 17:08:15 PDT 
[chromium] Make PlatformMessagePortChannel's destructor virtual
Comment 1 Nico Weber 2011-06-03 17:09:13 PDT 
Created attachment 95993 [details]
Patch
Comment 2 Nico Weber 2011-06-03 17:09:57 PDT 
Advantage of making only the leaf virtual: We don't need to touch WebCore here and annoy other ports (if they find changes of  this type annoying)
Comment 3 Nico Weber 2011-06-03 17:14:43 PDT 
Ignore the above comment; the interface is in chromiums webkit, so the comment is bogus
Comment 4 WebKit Review Bot 2011-06-04 03:58:59 PDT 
Comment on attachment 95993 [details]
Patch

Clearing flags on attachment: 95993

Committed r88107: <http://trac.webkit.org/changeset/88107>
Comment 5 WebKit Review Bot 2011-06-04 03:59:03 PDT 
All reviewed patches have been landed.  Closing bug.