Bug 62065 - [chromium] Make WebFrameImpl destructor virtual
Summary: [chromium] Make WebFrameImpl destructor virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 16:32 PDT by Nico Weber
Modified: 2011-06-04 03:42 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.48 KB, patch)
2011-06-03 16:34 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-06-03 16:32:47 PDT 
[chromium] Make WebFrameImpl destructor virtual
Comment 1 Nico Weber 2011-06-03 16:34:44 PDT 
Created attachment 95984 [details]
Patch
Comment 2 James Robinson 2011-06-03 16:50:54 PDT 
Comment on attachment 95984 [details]
Patch

WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here).
Comment 3 Nico Weber 2011-06-03 16:53:00 PDT 
(In reply to comment #2)
> (From update of attachment 95984 [details])
> WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here).

Again, why? Nobody deletes a WebFrame directly, and its destructor is protected, so it won't happen accidentally.
Comment 4 WebKit Review Bot 2011-06-04 03:42:30 PDT 
Comment on attachment 95984 [details]
Patch

Clearing flags on attachment: 95984

Committed r88105: <http://trac.webkit.org/changeset/88105>
Comment 5 WebKit Review Bot 2011-06-04 03:42:34 PDT 
All reviewed patches have been landed.  Closing bug.