RESOLVED FIXED 62065
[chromium] Make WebFrameImpl destructor virtual 
https://bugs.webkit.org/show_bug.cgi?id=62065
Summary [chromium] Make WebFrameImpl destructor virtual
Nico Weber
Reported 2011-06-03 16:32:47 PDT
[chromium] Make WebFrameImpl destructor virtual
Attachments
Patch (1.48 KB, patch)
2011-06-03 16:34 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2011-06-03 16:34:44 PDT
Created attachment 95984 [details] Patch
James Robinson
Comment 2 2011-06-03 16:50:54 PDT
Comment on attachment 95984 [details] Patch WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here).
Nico Weber
Comment 3 2011-06-03 16:53:00 PDT
(In reply to comment #2) > (From update of attachment 95984 [details]) > WebFrame.h declares ~WebFrame() { }, so it should declare virtual there as well (of course you also need to declare virtual here). Again, why? Nobody deletes a WebFrame directly, and its destructor is protected, so it won't happen accidentally.
WebKit Review Bot
Comment 4 2011-06-04 03:42:30 PDT
Comment on attachment 95984 [details] Patch Clearing flags on attachment: 95984 Committed r88105: <http://trac.webkit.org/changeset/88105>
WebKit Review Bot
Comment 5 2011-06-04 03:42:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.