RESOLVED FIXED 62046
Allow existing AudioParams to use scheduled parameter changes 
https://bugs.webkit.org/show_bug.cgi?id=62046
Summary Allow existing AudioParams to use scheduled parameter changes
Chris Rogers
Reported 2011-06-03 13:17:53 PDT
Allow existing AudioParams to use scheduled parameter changes
Attachments
Patch (9.40 KB, patch)
2011-06-03 13:24 PDT, Chris Rogers 		kbr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-06-03 13:24:53 PDT
Created attachment 95956 [details] Patch
Kenneth Russell
Comment 2 2011-06-03 13:42:10 PDT
Comment on attachment 95956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95956&action=review Looks good to me. One minor comment. > Source/WebCore/platform/audio/AudioBus.cpp:385 > + const float* source = sourceBus.channel(channelIndex)->data(); > + float* destination = channel(channelIndex)->data(); > + for (unsigned i = 0; i < numberOfGainValues; ++i) > + destination[i] = source[i] * gainValues[i]; > + } > + } else if (sourceBus.numberOfChannels() == 1) { > + const float* source = sourceBus.channel(0)->data(); > + for (unsigned channelIndex = 0; channelIndex < numberOfChannels(); ++channelIndex) { > + float* destination = channel(channelIndex)->data(); > + for (unsigned i = 0; i < numberOfGainValues; ++i) > + destination[i] = source[i] * gainValues[i]; Would be nice to avoid the duplicated code.
Chris Rogers
Comment 3 2011-06-03 14:18:21 PDT
Comment on attachment 95956 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95956&action=review >> Source/WebCore/platform/audio/AudioBus.cpp:385 >> + destination[i] = source[i] * gainValues[i]; > > Would be nice to avoid the duplicated code. Agreed. I'll try to coalesce these two cases.
Chris Rogers
Comment 4 2011-06-03 16:03:17 PDT
Committed r88074: <http://trac.webkit.org/changeset/88074>
Note You need to log in before you can comment on or make changes to this bug.