Bug 62042 - Fix IntRect::expand(const IntSize& size)
Summary: Fix IntRect::expand(const IntSize& size)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 12:53 PDT by Emil A Eklund
Modified: 2011-06-04 00:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.30 KB, patch)
2011-06-03 12:57 PDT, Emil A Eklund
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2011-06-03 12:53:49 PDT
The IntSize version of IntRect::expand currently moves the rect instead of resizing it. This is clearly incorrect.
It was introduced about a month ago in r86377 and is not used anywhere yet.
Comment 1 Emil A Eklund 2011-06-03 12:57:07 PDT
Created attachment 95949 [details]
Patch
Comment 2 Andreas Kling 2011-06-03 13:05:47 PDT
Comment on attachment 95949 [details]
Patch

o_O
Comment 3 Emil A Eklund 2011-06-03 13:07:43 PDT
Thanks for the quick review Andreas!
Comment 4 Andreas Kling 2011-06-03 13:12:09 PDT
(In reply to comment #3)
> Thanks for the quick review Andreas!

No problem! Now go use the function so we don't have to remove it. :)
Comment 5 Emil A Eklund 2011-06-03 13:14:08 PDT
> No problem! Now go use the function so we don't have to remove it. :)

I have a couple of patches for that coming up :)
Comment 6 WebKit Commit Bot 2011-06-04 00:02:51 PDT
Comment on attachment 95949 [details]
Patch

Clearing flags on attachment: 95949

Committed r88096: <http://trac.webkit.org/changeset/88096>
Comment 7 WebKit Commit Bot 2011-06-04 00:02:55 PDT
All reviewed patches have been landed.  Closing bug.