Bug 62040 - Support FontCustomPlatformData on Skia-Mac-Chrome variant
Summary: Support FontCustomPlatformData on Skia-Mac-Chrome variant
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cary Clark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 12:36 PDT by Cary Clark
Modified: 2011-06-03 17:22 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2011-06-03 13:55 PDT, Cary Clark 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-06-03 12:36:56 PDT 
Support FontCustomPlatformData on Skia-Mac-Chrome variant
Comment 1 Cary Clark 2011-06-03 13:55:14 PDT 
Created attachment 95959 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-03 14:30:19 PDT 
Comment on attachment 95959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95959&action=review

This approach seems reasonable.

> Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp:60
> +            // This is request for the length of the stream.
> +            return m_buffer->size();

What an awkward api!
Comment 3 WebKit Commit Bot 2011-06-03 17:22:19 PDT 
Comment on attachment 95959 [details]
Patch

Clearing flags on attachment: 95959

Committed r88081: <http://trac.webkit.org/changeset/88081>
Comment 4 WebKit Commit Bot 2011-06-03 17:22:24 PDT 
All reviewed patches have been landed.  Closing bug.