Bug 62037 - Switch paintCaret and paintDragCaret to use IntPoint
Summary: Switch paintCaret and paintDragCaret to use IntPoint
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 60318
  Show dependency tree / graph
 
Reported: 2011-06-03 12:02 PDT by Levi Weintraub
Modified: 2011-06-03 19:36 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.24 KB, patch)
2011-06-03 12:25 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-03 12:02:21 PDT 
Ongoing tx/ty removal.
Comment 1 Levi Weintraub 2011-06-03 12:05:33 PDT 
Two is today's magic number.
Comment 2 Levi Weintraub 2011-06-03 12:25:04 PDT 
Created attachment 95944 [details]
Patch
Comment 3 Levi Weintraub 2011-06-03 13:57:47 PDT 
Comment on attachment 95944 [details]
Patch

Clearing flags on attachment: 95944

Committed r88050: <http://trac.webkit.org/changeset/88050>
Comment 4 Levi Weintraub 2011-06-03 13:57:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 James Simonsen 2011-06-03 18:55:50 PDT 
This caused the Mac Clang bot to fail. Can you take a look?

http://build.chromium.org/p/chromium/builders/Mac%20Clang%20%28dbg%29/builds/3810/steps/compile/logs/stdio
Comment 6 Nico Weber 2011-06-03 19:30:04 PDT 
Hi this breaks the clang build thusly:

clang:warning: argument unused during compilation: '-fobjc-exceptions'
/b/build/slave/Mac_Clang__dbg_/build/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../webaudio/AudioParamTimeline.cpp:231:39:error: operands of ? are integers of different signs: 'unsigned int' and 'int' [-Werror,-Wsign-compare]
        int nextEventType = nextEvent ? nextEvent->type() : -1 /* unknown */;

Can you fix?
Comment 7 Eric Seidel (no email) 2011-06-03 19:32:51 PDT 
That can't be this change.
Comment 8 Nico Weber 2011-06-03 19:36:20 PDT 
Sorry, meant to comment on bug 61830 9_9