Bug 62029 - Cleanup member variable usage in svg/animation classes
Summary: Cleanup member variable usage in svg/animation classes
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
Depends on:
Reported: 2011-06-03 10:03 PDT by Rob Buis
Modified: 2011-06-03 12:37 PDT (History)
1 user (show)

See Also:

Patch (5.47 KB, patch)
2011-06-03 10:07 PDT, Rob Buis
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2011-06-03 10:03:38 PDT
There is one case where member var reordering decreases the class instance size, and another one where member vars can be removed since the state does not need to be stored, it is just used once.
Comment 1 Rob Buis 2011-06-03 10:07:13 PDT
Created attachment 95925 [details]
Comment 2 Nikolas Zimmermann 2011-06-03 12:25:07 PDT
Comment on attachment 95925 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=95925&action=review

r=me with a comment:

> Source/WebCore/svg/animation/SMILTimeContainer.cpp:222
> +void SMILTimeContainer::updateAnimations(SMILTime elapsed, double nextManualSampleTime, String nextSamplingTarget)

Use const String&.

> Source/WebCore/svg/animation/SMILTimeContainer.h:73
> +    void updateAnimations(SMILTime elapsed, double nextManualSampleTime = 0, String nextSamplingTarget = String());

Do we need the default params? If yes, you can't switch const String&...
Comment 3 Rob Buis 2011-06-03 12:37:34 PDT
Committed r88039: <http://trac.webkit.org/changeset/88039>