Bug 62022 - Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
Summary: Style Checker should flag removal of "developmentRegion = English;" from proj...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 08:39 PDT by David Levin
Modified: 2011-06-30 20:00 PDT (History)
2 users (show)

See Also:

Attachments
Patch V0 (9.33 KB, patch)
2011-06-30 19:32 PDT, Kenichi Ishibashi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2011-06-03 08:39:06 PDT 
For example see https://bugs.webkit.org/attachment.cgi?id=95523&action=prettypatch
Comment 1 Alexey Proskuryakov 2011-06-03 12:25:31 PDT 
And it should ideally suggest what to do so that this doesn't happen again!
Comment 2 Kenichi Ishibashi 2011-06-30 19:32:54 PDT 
Created attachment 99417 [details]
Patch V0
Comment 3 Darin Adler 2011-06-30 19:47:01 PDT 
Comment on attachment 99417 [details]
Patch V0

Seems fine.
Comment 4 Kenichi Ishibashi 2011-06-30 19:59:51 PDT 
Comment on attachment 99417 [details]
Patch V0

Clearing flags on attachment: 99417

Committed r90197: <http://trac.webkit.org/changeset/90197>
Comment 5 Kenichi Ishibashi 2011-06-30 19:59:57 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kenichi Ishibashi 2011-06-30 20:00:59 PDT 
Hi Darin,

Thank you for prompt review!

(In reply to comment #3)
> (From update of attachment 99417 [details])
> Seems fine.