RESOLVED FIXED 62014
Undefined reference to v8::HeapProfiler::DefineWrapperClass() due to ScriptProfiler::initialize() 
https://bugs.webkit.org/show_bug.cgi?id=62014
Summary Undefined reference to v8::HeapProfiler::DefineWrapperClass() due to ScriptPr...
Steve Block
Reported 2011-06-03 07:35:02 PDT
http://trac.webkit.org/changeset/81265 added ScriptProfiler::initialize(), which calls v8::HeapProfiler::DefineWrapperClass(). On Android, this gives a linker error because we build v8 without ENABLE_LOGGING_AND_PROFILING defined. Should there be enable guard around either the call site (in V8DOMWindowShell::initContextIfNeeded()) or implementation of ScriptProfiler::initialize() ?
Attachments
Add attachment proposed patch, testcase, etc.
Mikhail Naganov
Comment 1 2011-06-03 07:44:26 PDT
I'm sorry! Will fix today.
Mikhail Naganov
Comment 2 2011-06-03 12:49:55 PDT
Fixed in V8: http://code.google.com/p/v8/source/detail?r=8170 I have defined stub implementations when profiling is disabled (consistent with the rest of the API implementation). BTW, we are planning to do something with this option, as Crankshaft can't work w/o profiler parts. See http://code.google.com/p/v8/issues/detail?id=1271
Steve Block
Comment 3 2011-06-06 02:08:28 PDT
Thanks Mikhail
Note You need to log in before you can comment on or make changes to this bug.