Bug 62009 - IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
Summary: IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-03 05:43 PDT by Hans Wennborg
Modified: 2011-06-03 08:03 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.42 KB, patch)
2011-06-03 05:45 PDT, Hans Wennborg 		no flags Details | Formatted Diff | Diff
Patch (14.69 KB, patch)
2011-06-03 07:45 PDT, Hans Wennborg 		steveblock: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-06-03 05:43:04 PDT 
IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end
Comment 1 Hans Wennborg 2011-06-03 05:45:24 PDT 
Created attachment 95901 [details]
Patch
Comment 2 Hans Wennborg 2011-06-03 05:46:33 PDT 
Some clean-up that's been asked for in previous reviews.
Comment 3 Steve Block 2011-06-03 06:03:52 PDT 
Comment on attachment 95901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review

> Source/WebCore/storage/IDBLevelDBCoding.cpp:755
> +    return encode(INT64_MAX);

Should the FIXME for INT64_MAX in this file be removed?
Comment 4 Hans Wennborg 2011-06-03 06:09:11 PDT 
Comment on attachment 95901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review

>> Source/WebCore/storage/IDBLevelDBCoding.cpp:755
>> +    return encode(INT64_MAX);
> 
> Should the FIXME for INT64_MAX in this file be removed?

Yes, I'll do that.
Comment 5 Hans Wennborg 2011-06-03 07:45:05 PDT 
Created attachment 95911 [details]
Patch
Comment 6 Steve Block 2011-06-03 07:47:24 PDT 
Comment on attachment 95911 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2011-06-03 07:55:19 PDT 
Comment on attachment 95911 [details]
Patch

Rejecting attachment 95911 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8764126
Comment 8 Hans Wennborg 2011-06-03 08:03:10 PDT 
Committed r88019: <http://trac.webkit.org/changeset/88019>