Bug 62009 – IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Hans Wennborg]

IndexedDB: Clean-up use of INT64_MAX in LevelDB back-end

[Hans Wennborg]

Created attachment 95901 [details]
Patch

[Hans Wennborg]

Some clean-up that's been asked for in previous reviews.

[Steve Block]

Comment on attachment 95901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review

> Source/WebCore/storage/IDBLevelDBCoding.cpp:755
> +    return encode(INT64_MAX);

Should the FIXME for INT64_MAX in this file be removed?

[Hans Wennborg]

Comment on attachment 95901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95901&action=review

>> Source/WebCore/storage/IDBLevelDBCoding.cpp:755
>> +    return encode(INT64_MAX);
> 
> Should the FIXME for INT64_MAX in this file be removed?

Yes, I'll do that.

[Hans Wennborg]

Created attachment 95911 [details]
Patch

[Steve Block]

Comment on attachment 95911 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 95911 [details]
Patch

Rejecting attachment 95911 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8764126

[Hans Wennborg]

Committed r88019: <http://trac.webkit.org/changeset/88019>