Bug 61998 - [EFL] Implement startDownload() in FrameLoaderClientEfl
Summary: [EFL] Implement startDownload() in FrameLoaderClientEfl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 62017
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-03 01:01 PDT by Gyuyoung Kim
Modified: 2011-06-06 18:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2011-06-03 01:03 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2011-06-06 17:29 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-06-03 01:01:01 PDT 
Implement startDownload(). I think startDownload() operation is same with download().
Comment 1 Gyuyoung Kim 2011-06-03 01:03:37 PDT 
Created attachment 95869 [details]
Patch
Comment 2 WebKit Commit Bot 2011-06-03 07:17:57 PDT 
Comment on attachment 95869 [details]
Patch

Clearing flags on attachment: 95869

Committed r88014: <http://trac.webkit.org/changeset/88014>
Comment 3 WebKit Commit Bot 2011-06-03 07:18:02 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Antonio Gomes 2011-06-03 07:48:14 PDT 
Scanning dependencies of target ewebkit
[100%] Building CXX object WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o
/mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp: In member function ‘virtual void WebCore::FrameLoaderClientEfl::startDownload(const WebCore::ResourceRequest&)’:
/mnt/buildbot/efl-linux-slave-1/efl-linux-release/build/Source/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp:875: error: ‘const class WebCore::KURL’ has no member named ‘prettyURL’
make[2]: *** [WebKit/CMakeFiles/ewebkit.dir/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.o] Error 1
make[1]: *** [WebKit/CMakeFiles/ewebkit.dir/all] Error 2
Comment 5 Antonio Gomes 2011-06-03 08:50:36 PDT 
Rolled out. Please re-push a patch that builds.
Comment 6 Gyuyoung Kim 2011-06-06 17:29:47 PDT 
Created attachment 96162 [details]
Patch
Comment 7 Gyuyoung Kim 2011-06-06 17:54:49 PDT 
Comment on attachment 96162 [details]
Patch

Hmm, strange build error. There is no build problem in my local box. If this patch make build break again, I'm going to roll out again.
Comment 8 WebKit Review Bot 2011-06-06 18:03:40 PDT 
Comment on attachment 96162 [details]
Patch

Clearing flags on attachment: 96162

Committed r88207: <http://trac.webkit.org/changeset/88207>
Comment 9 WebKit Review Bot 2011-06-06 18:03:47 PDT 
All reviewed patches have been landed.  Closing bug.