Bug 61991 - Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
Summary: Assertion fails in TextCheckingHelper by right-clicking on <input type=search>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Hajime Morrita
URL: data:text/html,<input type=search>
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 20:59 PDT by Kent Tamura
Modified: 2011-06-06 18:44 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.60 KB, patch)
2011-06-06 03:28 PDT, Hajime Morrita 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-06-02 20:59:55 PDT 
1. Open data:text/html,<input type=search>
2. Right-click on a place where a cancel button should be on.

Result:
ARGUMENT BAD: m_range, m_range
/Volumes/d2/WebKit/Source/WebCore/editing/TextCheckingHelper.cpp(160) : WebCore::TextCheckingHelper::TextCheckingHelper(WebCore::EditorClient*, WTF::PassRefPtr<WebCore::Range>)
1   WebCore::TextCheckingHelper::TextCheckingHelper(WebCore::EditorClient*, WTF::PassRefPtr<WebCore::Range>)
2   WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection(bool&, bool&)
3   WebCore::ContextMenuController::populate()
4   WebCore::ContextMenuController::handleContextMenuEvent(WebCore::Event*)
5   WebCore::Node::defaultEventHandler(WebCore::Event*)
6   WebCore::SearchFieldCancelButtonElement::defaultEventHandler(WebCore::Event*)
7   WebCore::EventDispatcher::dispatchEvent(WTF::PassRefPtr<WebCore::Event>)
8   WebCore::MouseEventDispatchMediator::dispatchEvent(WebCore::EventDispatcher*) const
9   WebCore::EventDispatcher::dispatchEvent(WebCore::Node*, WebCore::EventDispatchMediator const&)
10  WebCore::Node::dispatchMouseEvent(WebCore::PlatformMouseEvent const&, WTF::AtomicString const&, int, WebCore::Node*)
11  WebCore::EventHandler::dispatchMouseEvent(WTF::AtomicString const&, WebCore::Node*, bool, int, WebCore::PlatformMouseEvent const&, bool)
12  WebCore::EventHandler::sendContextMenuEvent(WebCore::PlatformMouseEvent const&)
13  -[WebHTMLView menuForEvent:]
14  -[NSView rightMouseDown:]

Note: If the search field has a on-empty value and the cancel button is visible, this doesn't happen.
Comment 1 Hajime Morrita 2011-06-06 03:28:37 PDT 
Created attachment 96073 [details]
Patch
Comment 2 Kent Tamura 2011-06-06 03:36:24 PDT 
Comment on attachment 96073 [details]
Patch

Looks ok
Comment 3 Hajime Morrita 2011-06-06 18:44:45 PDT 
Committed r88211: <http://trac.webkit.org/changeset/88211>