Bug 61990 - Rename HTMLInputElement::m_value to m_valueIfDirty
Summary: Rename HTMLInputElement::m_value to m_valueIfDirty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-02 20:43 PDT by Keishi Hattori
Modified: 2011-06-07 23:19 PDT (History)
3 users (show)

See Also:

Attachments
patch (5.78 KB, patch)
2011-06-02 20:55 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
fixed typo (5.78 KB, patch)
2011-06-02 21:06 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2011-06-02 20:43:34 PDT 
Discussed in Bug 61857.

HTMLInputElement::m_value only contain the value of the element when the dirty value flag is true. Otherwise the value is taken from the "value" attribute. 

It should be renamed because it is confusing.
Comment 1 Keishi Hattori 2011-06-02 20:55:47 PDT 
Created attachment 95849 [details]
patch
Comment 2 Kent Tamura 2011-06-02 21:02:39 PDT 
Comment on attachment 95849 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95849&action=review

> Source/WebCore/html/HTMLInputElement.h:142
> +    bool hadDirtyValue() const { return !m_valueIfDirty.isNull(); };

Why 'had'?  I think it should be 'has'.
Comment 3 Keishi Hattori 2011-06-02 21:06:47 PDT 
Created attachment 95851 [details]
fixed typo
Comment 4 Keishi Hattori 2011-06-02 21:07:31 PDT 
> Why 'had'?  I think it should be 'has'.

Sorry, typo.
Comment 5 Kent Tamura 2011-06-02 21:17:55 PDT 
Comment on attachment 95851 [details]
fixed typo

ok
Comment 6 WebKit Review Bot 2011-06-07 23:19:02 PDT 
Comment on attachment 95851 [details]
fixed typo

Clearing flags on attachment: 95851

Committed r88329: <http://trac.webkit.org/changeset/88329>
Comment 7 WebKit Review Bot 2011-06-07 23:19:06 PDT 
All reviewed patches have been landed.  Closing bug.