RESOLVED FIXED 61990
Rename HTMLInputElement::m_value to m_valueIfDirty 
https://bugs.webkit.org/show_bug.cgi?id=61990
Summary Rename HTMLInputElement::m_value to m_valueIfDirty
Keishi Hattori
Reported 2011-06-02 20:43:34 PDT
Discussed in Bug 61857. HTMLInputElement::m_value only contain the value of the element when the dirty value flag is true. Otherwise the value is taken from the "value" attribute. It should be renamed because it is confusing.
Attachments
patch (5.78 KB, patch)
2011-06-02 20:55 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
fixed typo (5.78 KB, patch)
2011-06-02 21:06 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-06-02 20:55:47 PDT
Created attachment 95849 [details] patch
Kent Tamura
Comment 2 2011-06-02 21:02:39 PDT
Comment on attachment 95849 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=95849&action=review > Source/WebCore/html/HTMLInputElement.h:142 > + bool hadDirtyValue() const { return !m_valueIfDirty.isNull(); }; Why 'had'? I think it should be 'has'.
Keishi Hattori
Comment 3 2011-06-02 21:06:47 PDT
Created attachment 95851 [details] fixed typo
Keishi Hattori
Comment 4 2011-06-02 21:07:31 PDT
> Why 'had'? I think it should be 'has'. Sorry, typo.
Kent Tamura
Comment 5 2011-06-02 21:17:55 PDT
Comment on attachment 95851 [details] fixed typo ok
WebKit Review Bot
Comment 6 2011-06-07 23:19:02 PDT
Comment on attachment 95851 [details] fixed typo Clearing flags on attachment: 95851 Committed r88329: <http://trac.webkit.org/changeset/88329>
WebKit Review Bot
Comment 7 2011-06-07 23:19:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.