Bug 61981 - nrwt: fix duplicate logging regression
Summary: nrwt: fix duplicate logging regression
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
Depends on:
Reported: 2011-06-02 17:47 PDT by Dirk Pranke
Modified: 2011-06-03 12:00 PDT (History)
2 users (show)

See Also:

Patch (1.85 KB, patch)
2011-06-02 17:48 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff
Patch (1.98 KB, patch)
2011-06-02 17:56 PDT, Dirk Pranke
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-06-02 17:47:44 PDT
nrwt: fix duplicate logging regression
Comment 1 Dirk Pranke 2011-06-02 17:48:10 PDT
Created attachment 95841 [details]
Comment 2 Dirk Pranke 2011-06-02 17:49:45 PDT
I apparently re-introduced the "duplicate logging" issue due to a bad merge in bug 60328. This fixes it.

There's no test for this because it's difficult to do given the need for multiple processes and actual shared pipes. Good thing it's trivially easy to verify by eye :)
Comment 3 Dirk Pranke 2011-06-02 17:53:57 PDT
Comment on attachment 95841 [details]

whoops. this patch won't work.
Comment 4 Dirk Pranke 2011-06-02 17:56:01 PDT
Created attachment 95842 [details]
Comment 5 Dirk Pranke 2011-06-03 12:00:18 PDT
Committed r88035: <http://trac.webkit.org/changeset/88035>