if (!store->domData()->owningThread() == WTF::currentThread()) (misplaced boolean negation) and others
Created attachment 95812 [details] Fixes
Attachment 95812 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/v8/DOMData.h:88: More than one command on the same line in if [whitespace/parens] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 95815 [details] Style fixes
Comment on attachment 95815 [details] Style fixes Did you run the Dromeo DOM core benchmark on this change?
Comment on attachment 95815 [details] Style fixes In particular, WTF::currentThread() is very slow.
Comment on attachment 95815 [details] Style fixes View in context: https://bugs.webkit.org/attachment.cgi?id=95815&action=review > Source/WebCore/bindings/v8/DOMData.h:88 > + if (store->domData()->owningThread() != WTF::currentThread()) Actually I take back my r+. Why is this change correct? How does this function get called on the wrong thread? And if it get called on the wrong thread, won't there be problems since removeIfPresent wasn't called?
Comment on attachment 95815 [details] Style fixes View in context: https://bugs.webkit.org/attachment.cgi?id=95815&action=review >> Source/WebCore/bindings/v8/DOMData.h:88 >> + if (store->domData()->owningThread() != WTF::currentThread()) > > Actually I take back my r+. Why is this change correct? > > How does this function get called on the wrong thread? And if it get called on the wrong thread, won't there be problems since removeIfPresent wasn't called? This function only gets called on a wrong thread in (future) patch with Isolates, and currently DOM stores are affined to the threads. But it is not a good function indeed - it accesses the stores list without a mutex anyway, so doesn't really work in multithreaded situation; and the above has performance problems. I'll revert this bit, and restructure this for isolates in later fix.