Bug 61961 – [chromium] Chromium bots on build.webkit.org don't upload results.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

None of Chromium Windows, Mac, or Linux upload results.html and other files.  As a result, we can't see any diffs or stderr from build.webkit.org.

[Ryosuke Niwa]

The problem is that we fix dir. path in test-result-archive:

    if options.platform == 'chromium':
        # See results_directory() in webkitpy/layout_tests/port/chromium.py.
        layoutTestResultsDir = os.path.abspath(os.path.join(sourceRootDirectory,
            "Source", "WebKit", "chromium", "webkit", options.configuration.capitalize(),
            "layout-test-results"))

Since we're running this script with the following arguments & path:

python ./Tools/BuildSlaveSupport/test-result-archive --platform=chromium --release archive
 in dir /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release-tests/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['python', './Tools/BuildSlaveSupport/test-result-archive', '--platform=chromium', '--release', 'archive']

and test results live in /Users/chrome-bot/Desktop/WebKit-BuildSlave/chromium-mac-release-tests/build/layout-test-results
we shouldn't be doing this fix up.

I think this bug goes away if we get rid of the offending lines in test-result-archive.

Or am I missing something?

[Tony Chang]

That sounds right.  We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree.

If you want to be thorough, you can run a buildbot on your desktop.

[Ryosuke Niwa]

(In reply to comment #2)
> That sounds right.  We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree.
> 
> If you want to be thorough, you can run a buildbot on your desktop.

Are there instructions on how to do it?  Ideally, I can test it myself before making this change.  Or I land the change in weekend when nobody is landing patches.

[Tony Chang]

(In reply to comment #3)
> (In reply to comment #2)
> > That sounds right.  We used to put the results in Source/WebKit/chromium/webkit, but now the results should just be in the root of the source tree.
> > 
> > If you want to be thorough, you can run a buildbot on your desktop.
> 
> Are there instructions on how to do it?  Ideally, I can test it myself before making this change.  Or I land the change in weekend when nobody is landing patches.

http://trac.webkit.org/wiki/BuildBot has instructions for running a slave.  I can show you how to set up a master as well.  If you plan on making future changes to the bots, this is probably worth doing.

If not, then this change seems pretty safe and the worst case scenario is that test-result-archive continues to not work on the Chromium slaves.

[Ryosuke Niwa]

Created attachment 96158 [details]
fixes the bug

[Ryosuke Niwa]

I have verified that his change at least fixes Mac bot.

[Ryosuke Niwa]

Comment on attachment 96158 [details]
fixes the bug

Clearing flags on attachment: 96158

Committed r88210: <http://trac.webkit.org/changeset/88210>

[Ryosuke Niwa]

All reviewed patches have been landed.  Closing bug.